Skip to content

Commit f4ad938

Browse files
author
신원세/프론트엔드개발팀
committed
Refactor Jobs page event handlers with explicit block syntax
1 parent 74762a3 commit f4ad938

2 files changed

Lines changed: 28 additions & 10 deletions

File tree

.github/workflows/deploy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
env:
2121
API_TOKEN_GITHUB: ${{ secrets.AUTO_ACTIONS }}
2222
with:
23-
source-directory: 'output'
23+
source-directory: 'build'
2424
destination-github-username: shinwonse
2525
destination-repository-name: kufe
2626
user-email: ${{ secrets.EMAIL }}

app/routes/jobs.tsx

Lines changed: 27 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,9 @@ export default function Jobs() {
245245
placeholder="Search by job title, company, or skill..."
246246
className={cn('pl-10 h-12')}
247247
value={searchQuery}
248-
onChange={(e) => setSearchQuery(e.target.value)}
248+
onChange={(e) => {
249+
setSearchQuery(e.target.value);
250+
}}
249251
/>
250252
</div>
251253

@@ -269,7 +271,9 @@ export default function Jobs() {
269271
'rounded-md border border-input bg-background h-9 px-3 text-sm',
270272
)}
271273
value={selectedLocation}
272-
onChange={(e) => setSelectedLocation(e.target.value)}
274+
onChange={(e) => {
275+
setSelectedLocation(e.target.value);
276+
}}
273277
>
274278
{locations.map((location) => (
275279
<option key={location} value={location}>
@@ -283,7 +287,9 @@ export default function Jobs() {
283287
'rounded-md border border-input bg-background h-9 px-3 text-sm',
284288
)}
285289
value={selectedExperience}
286-
onChange={(e) => setSelectedExperience(e.target.value)}
290+
onChange={(e) => {
291+
setSelectedExperience(e.target.value);
292+
}}
287293
>
288294
{experienceLevels.map((level) => (
289295
<option key={level} value={level}>
@@ -297,7 +303,9 @@ export default function Jobs() {
297303
'rounded-md border border-input bg-background h-9 px-3 text-sm',
298304
)}
299305
value={selectedEmploymentType}
300-
onChange={(e) => setSelectedEmploymentType(e.target.value)}
306+
onChange={(e) => {
307+
setSelectedEmploymentType(e.target.value);
308+
}}
301309
>
302310
{employmentTypes.map((type) => (
303311
<option key={type} value={type}>
@@ -316,7 +324,9 @@ export default function Jobs() {
316324
'rounded-md border border-input bg-background h-9 px-3 text-sm',
317325
)}
318326
value={sortBy}
319-
onChange={(e) => setSortBy(e.target.value)}
327+
onChange={(e) => {
328+
setSortBy(e.target.value);
329+
}}
320330
>
321331
{sortOptions.map((option) => (
322332
<option key={option.value} value={option.value}>
@@ -342,7 +352,9 @@ export default function Jobs() {
342352
className={cn(
343353
'ml-1 text-muted-foreground hover:text-foreground',
344354
)}
345-
onClick={() => setSelectedLocation('All locations')}
355+
onClick={() => {
356+
setSelectedLocation('All locations');
357+
}}
346358
>
347359
×
348360
</button>
@@ -356,7 +368,9 @@ export default function Jobs() {
356368
className={cn(
357369
'ml-1 text-muted-foreground hover:text-foreground',
358370
)}
359-
onClick={() => setSelectedExperience('All levels')}
371+
onClick={() => {
372+
setSelectedExperience('All levels');
373+
}}
360374
>
361375
×
362376
</button>
@@ -370,7 +384,9 @@ export default function Jobs() {
370384
className={cn(
371385
'ml-1 text-muted-foreground hover:text-foreground',
372386
)}
373-
onClick={() => setSelectedEmploymentType('All types')}
387+
onClick={() => {
388+
setSelectedEmploymentType('All types');
389+
}}
374390
>
375391
×
376392
</button>
@@ -442,7 +458,9 @@ export default function Jobs() {
442458
'absolute right-3 top-3 flex h-8 w-8 items-center justify-center rounded-full bg-white/80 text-gray-600 transition-colors hover:bg-white',
443459
savedJobs.includes(job.id) ? 'text-primary' : '',
444460
)}
445-
onClick={() => toggleSaveJob(job.id)}
461+
onClick={() => {
462+
toggleSaveJob(job.id);
463+
}}
446464
aria-label={
447465
savedJobs.includes(job.id) ? 'Unsave job' : 'Save job'
448466
}

0 commit comments

Comments
 (0)