comments update, minor changes

Author: krowinski

src/MySQLReplication/BinLog/BinLogAuth.php

@@ -3,7 +3,8 @@
 namespace MySQLReplication\BinLog;
 
 /**
- * Class PackAuth
+ * Class BinLogAuth
+ * @package MySQLReplication\BinLog
  */
 class BinLogAuth
 {

src/MySQLReplication/BinLog/BinLogConnect.php

@@ -10,7 +10,8 @@
 use MySQLReplication\Gtid\GtidCollection;
 
 /**
- * Class Connect
+ * Class BinLogConnect
+ * @package MySQLReplication\BinLog
  */
 class BinLogConnect
 {
@@ -151,15 +152,16 @@ public function getPacket($checkForOkByte = true)
     public function isWriteSuccessful($packet)
     {
         $head = ord($packet[0]);
-        if (in_array($head, $this->packageOkHeader))
+        if (in_array($head, $this->packageOkHeader, true))
         {
             return ['status' => true, 'code' => 0, 'msg' => ''];
         }
         else
         {
             $error_code = unpack('v', $packet[1] . $packet[2])[1];
             $error_msg = '';
-            for ($i = 9; $i < strlen($packet); $i++)
+            $packetLength = strlen($packet);
+            for ($i = 9; $i < $packetLength; $i++)
             {
                 $error_msg .= $packet[$i];
             }

src/MySQLReplication/BinLog/BinLogServerInfo.php

@@ -3,8 +3,8 @@
 namespace MySQLReplication\BinLog;
 
 /**
- * Class ServerInfo
- * @package MySQLReplication\Pack
+ * Class BinLogServerInfo
+ * @package MySQLReplication\BinLog
  */
 class BinLogServerInfo
 {
@@ -50,31 +50,31 @@ public static function parsePackage($pack)
         {
             self::$serverInfo['salt'] .= $pack[$j];
         }
-        $i = $i + 8;
+        $i += 8;
 
         //filler_1 (1) -- 0x00
         $i++;
 
         //capability_flag_1 (2) -- lower 2 bytes of the Protocol::CapabilityFlags (optional)
-        $i = $i + 2;
+        $i += 2;
 
         //character_set (1) -- default server character-set, only the lower 8-bits Protocol::CharacterSet (optional)
         self::$serverInfo['character_set'] = $pack[$i];
         $i++;
 
         //status_flags (2) -- Protocol::StatusFlags (optional)
-        $i = $i + 2;
+        $i += 2;
 
         //capability_flags_2 (2) -- upper 2 bytes of the Protocol::CapabilityFlags
-        $i = $i + 2;
+        $i += 2;
 
         //auth_plugin_data_len (1) -- length of the combined auth_plugin_data, if auth_plugin_data_len is > 0
         $salt_len = ord($pack[$i]);
         $i++;
 
         $salt_len = max(12, $salt_len - 9);
 
-        $i = $i + 10;
+        $i += 10;
 
         //next salt
         if ($length >= $i + $salt_len)

src/MySQLReplication/BinLog/Exception/BinLogException.php

@@ -4,6 +4,10 @@
 
 use MySQLReplication\Exception\MySQLReplicationException;
 
+/**
+ * Class BinLogException
+ * @package MySQLReplication\BinLog\Exception
+ */
 class BinLogException extends MySQLReplicationException
 {
 }

src/MySQLReplication/BinaryDataReader/BinaryDataReaderBuilder.php

@@ -2,6 +2,10 @@
 
 namespace MySQLReplication\BinaryDataReader;
 
+/**
+ * Class BinaryDataReaderBuilder
+ * @package MySQLReplication\BinaryDataReader
+ */
 class BinaryDataReaderBuilder
 {
     private $binaryData = '';

src/MySQLReplication/BinaryDataReader/BinaryDataReaderService.php

@@ -3,13 +3,13 @@
 namespace MySQLReplication\BinaryDataReader;
 
 /**
- * Class PackageService
+ * Class BinaryDataReaderService
  * @package MySQLReplication\BinaryDataReader
  */
 class BinaryDataReaderService
 {
     /**
-     * @param string $binaryData
+     * @param $binaryData
      * @return BinaryDataReader
      */
     public function makePackageFromBinaryData($binaryData)

src/MySQLReplication/BinaryDataReader/Exception/BinaryDataReaderException.php

@@ -4,6 +4,10 @@
 
 use MySQLReplication\Exception\MySQLReplicationException;
 
+/**
+ * Class BinaryDataReaderException
+ * @package MySQLReplication\BinaryDataReader\Exception
+ */
 class BinaryDataReaderException extends MySQLReplicationException
 {
 }

src/MySQLReplication/Config/ConfigBuilder.php

@@ -3,7 +3,7 @@
 namespace MySQLReplication\Config;
 
 /**
- * Class Config
+ * Class ConfigBuilder
  * @package MySQLReplication\Config
  */
 class ConfigBuilder

src/MySQLReplication/Config/ConfigService.php

@@ -3,7 +3,7 @@
 namespace MySQLReplication\Config;
 
 /**
- * Class ConfigFactory
+ * Class ConfigService
  * @package MySQLReplication\Config
  */
 class ConfigService

src/MySQLReplication/Config/Exception/ConfigException.php

@@ -4,6 +4,10 @@
 
 use MySQLReplication\Exception\MySQLReplicationException;
 
+/**
+ * Class ConfigException
+ * @package MySQLReplication\Config\Exception
+ */
 class ConfigException extends MySQLReplicationException
 {
     const USER_ERROR_MESSAGE = 'Incorrect user given';