Skip to content

Commit 32a333d

Browse files
drfloobcopybara-github
authored andcommittedFeb 28, 2025
[EventEngine] Remove CFStream exception from PosixEventEngine (grpc#38875)
I believe this is now unnecessary, given CFEngine has been used in production for some time. Closes grpc#38875 COPYBARA_INTEGRATE_REVIEW=grpc#38875 from drfloob:rm-posix-ee-cfstream-exception b170dde PiperOrigin-RevId: 732201892
1 parent ac0eed3 commit 32a333d

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed
 

‎src/core/lib/event_engine/posix_engine/posix_engine.cc

+1-3
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,7 @@
6767

6868
// IWYU pragma: no_include <ratio>
6969

70-
// TODO(eryu): remove this GRPC_CFSTREAM condition when the CFEngine is ready.
71-
// The posix poller currently crashes iOS.
72-
#if defined(GRPC_POSIX_SOCKET_TCP) && !defined(GRPC_CFSTREAM) && \
70+
#if defined(GRPC_POSIX_SOCKET_TCP) && \
7371
!defined(GRPC_DO_NOT_INSTANTIATE_POSIX_POLLER)
7472
#define GRPC_PLATFORM_SUPPORTS_POSIX_POLLING true
7573
#else

‎src/core/lib/event_engine/shim.cc

+2-6
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222
namespace grpc_event_engine::experimental {
2323

2424
bool UseEventEngineClient() {
25-
// TODO(hork, eryu): Adjust the ifdefs accordingly when event engines become
26-
// available for other platforms.
27-
#if defined(GRPC_POSIX_SOCKET_TCP) && !defined(GRPC_CFSTREAM) && \
25+
#if defined(GRPC_POSIX_SOCKET_TCP) && \
2826
!defined(GRPC_DO_NOT_INSTANTIATE_POSIX_POLLER)
2927
return grpc_core::IsEventEngineClientEnabled();
3028
#elif defined(GPR_WINDOWS) && !defined(GRPC_DO_NOT_INSTANTIATE_POSIX_POLLER)
@@ -37,9 +35,7 @@ bool UseEventEngineClient() {
3735
}
3836

3937
bool UseEventEngineListener() {
40-
// TODO(hork, eryu): Adjust the ifdefs accordingly when event engines become
41-
// available for other platforms.
42-
#if defined(GRPC_POSIX_SOCKET_TCP) && !defined(GRPC_CFSTREAM) && \
38+
#if defined(GRPC_POSIX_SOCKET_TCP) && \
4339
!defined(GRPC_DO_NOT_INSTANTIATE_POSIX_POLLER)
4440
return grpc_core::IsEventEngineListenerEnabled();
4541
#else

0 commit comments

Comments
 (0)
Please sign in to comment.