Mdc aspect implementation #488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitrySadchikov
force-pushed
the
feature/mdc-aspect
branch
from
5fad817 to
4d822b8
Compare
DmitrySadchikov
changed the title
Open
GoodforGod
requested changes
Oct 22, 2025
logging/logging-common/src/main/java/ru/tinkoff/kora/logging/common/annotation/Mdc.java
Show resolved
Hide resolved
logging/declarative-logging/declarative-logging-annotation-processor/build.gradle
Outdated
Show resolved
Hide resolved
DmitrySadchikov
force-pushed
the
feature/mdc-aspect
branch
from
3d9a90d to
fd91803
Compare
GoodforGod
previously approved these changes
Oct 29, 2025
Squiry
requested changes
Oct 29, 2025
| final Set<String> keys = new HashSet<>(); | ||
| for (AnnotationMirror annotation : methodAnnotations) { | ||
| final String key = extractParameter(annotation, String.class, "key") | ||
| .orElseThrow(() -> new ProcessingErrorException("@Mdc annotation must have 'key' attribute", annotation.getAnnotationType().asElement())); |
There was a problem hiding this comment.
Раз уж он обязательный, то может быть и сделать его обязательным в аннотации и пусть его проверяет компилятор.
There was a problem hiding this comment.
вроде договорились что он в итоге не обязательный тк имя берется как имя аргумента
There was a problem hiding this comment.
Тут смысл в том, что для аннотации над методом оба параметры обязательны. А для аннотации на аргументе уже оба необязательны:
@Mdc // непонятно, что брать в качестве ключа и значения?
void test() {...}
// здесь наоборот, все понятно, вызовем MDC.put("name", name);
void test(@Mdc String name) {...}| } | ||
|
|
||
| private static <T> Optional<T> extractParameter(AnnotationMirror annotation, Class<T> type, String name) { | ||
| return annotation.getElementValues() |
There was a problem hiding this comment.
AnnotationUtils.parseAnnotationValueWithoutDefault
| currentContextBuilder.addStatement("var __$N = $N.get($S)", key, MDC_CONTEXT_VAR_NAME, key); | ||
| } | ||
| if (value.startsWith("${") && value.endsWith("}")) { | ||
| fillMdcBuilder.addStatement("$T.put($S, $N)", mdc, key, value.substring(2, value.length() - 1)); |
There was a problem hiding this comment.
$N - это для имени переменной, а у вас там судя по всему свободный код, для него есть $L.
DmitrySadchikov
force-pushed
the
feature/mdc-aspect
branch
from
ed6471b to
87ba375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Реализация задачи #144