-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide backchannel SSO logout endpoint #33
Comments
What do you mean with "optionally"? |
At the moment when logging off in Redmine (after logging into it with redmine_oauth) only redmine There should be a configurable option (just like the don't show password login option) to perform SSO Logout on logging out in Redmine. So that both the redmine session and the SSO session are ended. |
But OAuth can be used from more than one application. E.g. You log out from Redmine but you don't want to be logged out from Azure too. |
@picman you are right. If you end the session, then you only invalidate the redmine session, and as soon as you click the OpenId login (with a valid openid session) again, you will be logged into redmine again. You could end the whole SSO session by calling the respective IdP endpoint, but if e.g. Azure is not configured to get the backchannel logout information, then it will stick as is. So generally - every application after login has its own sesssion cookies running, and its a matter of how deep the specific application adopts SSO to what degree it will honor or prioritize SSO session information to its own session information. Lets fix the scenario another way round: You end your SSO session with the IdP directly - so you consider every application you logged in via SSO to end its current session. Maybe this should be the real feature we adopt - supporting backchannel logouts! Here you would have to provide an endpoint which gets called by the IdP telling you to logoff user X. |
I've implemented 'OAuth logout' if checked out in the settings. Could you test the logout branch please? |
Will check after #36 is integrated (easier ...) |
Merged into devel. |
I think that you can configure here for example a URL for password change and as soon as a user call a password change, it will log them out. You should leave it empty it shouldn't have anything to do with Redmine logout. |
Thank you @picman for the patch, i have several points/questions to this
|
I'm not sure about this at the moment, could we probably move this to 2.2.6 and give it some time to think about?! I could then re-arrange the issues with better descriptions feedback! |
Currently pressing Logoff in redmine only closes the redmine session. Optionally a full SSO logoff should be possible.
The text was updated successfully, but these errors were encountered: