Validation of addresses

[youkaicountry]

CLI currently allows non-address values to be passed in as address arguments.

Better validation in the parser should be added, by improving the regex. Additionally, the IsValidAddress function from util should be invoked by the parser.

Checksum should be ensured:
https://medium.com/coinmonks/how-to-generate-a-bitcoin-address-step-by-step-9d7fcbf1ad0b

The self keyword should also be allowed. The regex should ensure self is recognized as an address, and validation should not be done on it. Addresses that are "self" should resolve to the currently opened wallet address, if any.

PR #151 adds better validation via regex

[mvandeberg]

From #131

From the CLI

transfer 0.1 15UWU3BYRRJTA5I2U9BR19MDGFQBC7Z2RN
Note the casing of the address. The receiving targeted address was 15uWu3bYRrJta5i2U9br19mDGFqBc7z2rn.
The transaction was successful, but the receiving address was unexpected. 15UWU3BYRRJTA5

https://koinosblocks.com/tx/0x1220108592bf3ec2e86f5748791e3774db0d34933ceb4d1ab994e554227c2c45f7ef

It looks like there are a few issues. Please split and reassign if they pass triage.

The operation in the call contract uses the bad receiving address. I didn't verify the transaction args, but perhaps the CLI should validate and reject invalid addresses.
The transfer event shows that 15UWU3BYRRJTA5 should have received TKOIN. The sending address was decremented correctly, but the receiving account only received MANA? It difficult to tell if this is a UI bug in the explorer or if it's an actual error where MANA was recorded but the TKOIN was not.
https://koinosblocks.com/address/15UWU3BYRRJTA5
It's odd that the blockchain even accepts an address with this format. Do accounts not use a well known algorithm and checkum? It seems like you can transfer TKOIN to a bunch of odd address string.
transfer 0.3 somewhere
https://koinosblocks.com/tx/0x1220419647e106ab20332d37629674dae3745911902a43a773276ae6611da276dc02
https://koinosblocks.com/address/somewhere

[koinos-ci]

This issue is stale because it has been open for 30 days with no activity.