-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection Atomic Swaps #11331
Comments
i am not sure if we should anyhow use the swap UI we have now for review etc. |
@Jarsen136 can you please take this? |
Sure I would like to work on it. |
Collection Atomic Swaps is already supported in all places where we show either offers or swaps , so basically if you create one of these swaps (for example manually removing the desired item) ui wise it will work So what's is missing is being able to create them , both offer and swap See #11331 (comment) Also Collection counter swap is not supported Feel free to dm me if you have any other question |
Users should be able to create collection atomic-swaps
the main difference between this and other atomic-swaps is that the user has not selected a
desiredItem
inside thedesiredCollection
so any owner of nfts in that
desiredCollection
can accept the atomic-swap@exezbcz designs for
creating
andaccepting
these kind of swaps are neededsimplified requirements
Only a desiredCollection is needed and also
how to create one
Swaps
maybe we have. button inside a collection that redirects to the swap landing page but step "2" (where the user selects the nft they want is skipped) , swap review step should accommodate for this
Offer
issue: #11116
maybe we have. button inside a collection that opens this modal without the nft section
how to accept one
Any owner of nfts in the
desiredCollection
of that atomic-swap can accept that trade andselect
a nft from any that they ownThe text was updated successfully, but these errors were encountered: