Fix/starlight components auto allow imports

[jp-knj]

Summary

Linked Issues

• Closes #

Tasks from TODO.md

• Task 1.x: ...

Performance Evidence

Verification Steps

1. npm install && npm run build:napi
2. node scripts/smoke-napi.mjs samples/large.md
3. Result: ...

Checklist

• cargo fmt executed?
• cargo clippy passed?
• Tests passed?
• No secrets included?

[claude]

Code review

I found one issue during the review:

Unused function and unpopulated field

Files affected:

• packages/astro-markflow/src/utils/mdx-detection.ts (lines 72-80)
• packages/astro-markflow/src/vite-plugin.ts (lines 300-301)

Issue:
The extractExportStatements function is defined but never called anywhere in the codebase. Additionally, the MdxPatternDetectionResult.exports field is never populated by detectProblematicMdxPatterns.

This means the statistics tracking code in vite-plugin.ts that checks detection.exports will always find it undefined, resulting in fallbackStats.exports always being 0.

Impact:

• The fallback statistics breakdown will never show "X with exports"
• The extractExportStatements function is dead code
• The statistics are misleading (will always show 0 for exports)

Suggested fix:
Either:

1. Remove the unused extractExportStatements function and the exports field from the interface if exports are now fully handled by Rust and don't need tracking, OR
2. Populate detection.exports by calling extractExportStatements in detectProblematicMdxPatterns if export tracking is still desired

Code references:

• Unused function:

  markflow/packages/astro-markflow/src/utils/mdx-detection.ts

  Lines 71 to 81 in 2715fd6

  	*/
  	function extractExportStatements(content: string): string[] {
  	const exports: string[] = [];
  	const exportRegex = /^export\s+(const|let|var|function|class|default)\b/gm;
  	let match;
  	while ((match = exportRegex.exec(content)) !== null) {
  	exports.push(`export ${match[1]}`);
  	}
  	return exports;
  	}

• Unpopulated field checked here:

  markflow/packages/astro-markflow/src/vite-plugin.ts

  Lines 299 to 302 in 2715fd6

  	// Track statistics
  	if (detection.exports && detection.exports.length > 0) {
  	fallbackStats.exports++;
  	} else if (detection.disallowedImports && detection.disallowedImports.length > 0) {

• Field definition but never populated:

  markflow/packages/astro-markflow/src/utils/mdx-detection.ts

  Lines 127 to 153 in 2715fd6

  	return {
  	hasProblematicPatterns: true,
  	reason: `Contains imports with no allowImports configured: ${allImports.slice(0, 3).join(', ')}${allImports.length > 3 ? ` (+${allImports.length - 3} more)` : ''}`,
  	allImports,
  	disallowedImports: allImports,
  	};
  	}
  	// Check if all imports are from allowed sources
  	const disallowedImports = allImports.filter(
  	(src) => !isAllowedImport(src, allowImports)
  	);
  	if (disallowedImports.length > 0) {
  	return {
  	hasProblematicPatterns: true,
  	reason: `Contains disallowed imports: ${disallowedImports.slice(0, 3).join(', ')}${disallowedImports.length > 3 ? ` (+${disallowedImports.length - 3} more)` : ''}`,
  	allImports,
  	disallowedImports,
  	};
  	}
  	return {
  	hasProblematicPatterns: false,
  	allImports,
  	};
  	}

---

Summary: 1 issue found. Checked for bugs and CLAUDE.md compliance.