Repository navigation
Commit f2b9f9c
Skip disabling keep-alives when shutting down the webhook server (#3306)
My theory is that when this happens the go runtime will close
idle connections. If by chance the API server is making a
request and re-using a connection (that is closing) it will receive
an io.EOF. Thus introducing a flake.
So we now remove this setting change and let all the connections
close during the regular graceful shutdown. We would have
already lame ducked so the webhook shouldn't be receiving new
requests.
Co-authored-by: Dave Protasowski <dprotaso@gmail.com>1 parent 4ebd86b commit f2b9f9c
1 file changed
Lines changed: 0 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
333 | 333 | | |
334 | 334 | | |
335 | 335 | | |
336 | | - | |
337 | | - | |
338 | | - | |
339 | 336 | | |
340 | 337 | | |
341 | 338 | | |
| |||
0 commit comments