From 10d989ebfb33f3b05c4160c352ada549271cdf32 Mon Sep 17 00:00:00 2001 From: Vincent Date: Mon, 8 Jan 2024 20:36:50 -0500 Subject: [PATCH] Do not remove the resources if status.Manifests is empty (#1661) --- pkg/reconciler/knativeeventing/knativeeventing.go | 3 +++ pkg/reconciler/knativeserving/knativeserving.go | 3 +++ 2 files changed, 6 insertions(+) diff --git a/pkg/reconciler/knativeeventing/knativeeventing.go b/pkg/reconciler/knativeeventing/knativeeventing.go index c9d1bd9ea2..959656ef0d 100644 --- a/pkg/reconciler/knativeeventing/knativeeventing.go +++ b/pkg/reconciler/knativeeventing/knativeeventing.go @@ -169,6 +169,9 @@ func (r *Reconciler) injectNamespace(ctx context.Context, manifest *mf.Manifest, func (r *Reconciler) installed(ctx context.Context, instance base.KComponent) (*mf.Manifest, error) { paths := instance.GetStatus().GetManifests() + if len(paths) == 0 { + return nil, nil + } installed, err := common.FetchManifestFromArray(paths) if err != nil { diff --git a/pkg/reconciler/knativeserving/knativeserving.go b/pkg/reconciler/knativeserving/knativeserving.go index 08610b70dd..d554b73ddd 100644 --- a/pkg/reconciler/knativeserving/knativeserving.go +++ b/pkg/reconciler/knativeserving/knativeserving.go @@ -155,6 +155,9 @@ func (r *Reconciler) injectNamespace(ctx context.Context, manifest *mf.Manifest, func (r *Reconciler) installed(ctx context.Context, instance base.KComponent) (*mf.Manifest, error) { paths := instance.GetStatus().GetManifests() + if len(paths) == 0 { + return nil, nil + } installed, err := common.FetchManifestFromArray(paths) if err != nil { return &installed, err