Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consuming repos on stable branches are getting broken by changes to knative/actions #89

Open
cardil opened this issue Dec 7, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@cardil
Copy link
Contributor

cardil commented Dec 7, 2022

All our repos are reusing actions with by using @main version. The actions are evolving, which is normal, but that breaks those support branches.

We need to start creating tags or at least branches on knative/actions.

When incompatibility occurs we could switch failing repo to older, passing action ie.: @release-1.7. This approach has a disadvantage. People may be confused why their stable branch is broken...

We could also consider to proactively switch actions to branch of knative/actions at release day. This adds churn, but it ensures we can always release if needed.

@cardil cardil added the bug Something isn't working label Dec 7, 2022
@cardil
Copy link
Contributor Author

cardil commented Dec 7, 2022

Here's an example of exact situation: openshift-knative/kn-plugin-event#279

@krsna-m
Copy link
Contributor

krsna-m commented Mar 21, 2023

related #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants