Skip to content

Commit f9fd944

Browse files
committed
fix: removed unnecessary isActive modifier on the shutter DKs
1 parent 374b4f2 commit f9fd944

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

contracts/src/arbitration/dispute-kits/DisputeKitGatedShutter.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ contract DisputeKitGatedShutter is DisputeKitClassicBase {
118118
bytes32 _recoveryCommit,
119119
bytes32 _identity,
120120
bytes calldata _encryptedVote
121-
) external isActive(_coreDisputeID) {
121+
) external {
122122
if (_recoveryCommit == bytes32(0)) revert EmptyRecoveryCommit();
123123

124124
uint256 localDisputeID = coreDisputeIDToLocal[_coreDisputeID];
@@ -128,7 +128,7 @@ contract DisputeKitGatedShutter is DisputeKitClassicBase {
128128
recoveryCommitments[localDisputeID][localRoundID][_voteIDs[i]] = _recoveryCommit;
129129
}
130130

131-
// `_castCommit()` ensures that the caller owns the vote
131+
// `_castCommit()` ensures that the caller owns the vote and that dispute is active
132132
_castCommit(_coreDisputeID, _voteIDs, _commit);
133133
emit CommitCastShutter(_coreDisputeID, msg.sender, _commit, _recoveryCommit, _identity, _encryptedVote);
134134
}

contracts/src/arbitration/dispute-kits/DisputeKitShutter.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ contract DisputeKitShutter is DisputeKitClassicBase {
102102
bytes32 _recoveryCommit,
103103
bytes32 _identity,
104104
bytes calldata _encryptedVote
105-
) external isActive(_coreDisputeID) {
105+
) external {
106106
if (_recoveryCommit == bytes32(0)) revert EmptyRecoveryCommit();
107107

108108
uint256 localDisputeID = coreDisputeIDToLocal[_coreDisputeID];
@@ -112,7 +112,7 @@ contract DisputeKitShutter is DisputeKitClassicBase {
112112
recoveryCommitments[localDisputeID][localRoundID][_voteIDs[i]] = _recoveryCommit;
113113
}
114114

115-
// `_castCommit()` ensures that the caller owns the vote
115+
// `_castCommit()` ensures that the caller owns the vote and that dispute is active
116116
_castCommit(_coreDisputeID, _voteIDs, _commit);
117117
emit CommitCastShutter(_coreDisputeID, msg.sender, _commit, _recoveryCommit, _identity, _encryptedVote);
118118
}

0 commit comments

Comments
 (0)