Skip to content

Commit 592243f

Browse files
committed
fix: nitpicks from reviews
1 parent 6b8970a commit 592243f

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

contracts/src/arbitration/KlerosCore.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1266,14 +1266,14 @@ contract KlerosCore is IArbitratorV2, Initializable, UUPSProxiable {
12661266
newDisputeKitID >= disputeKits.length ||
12671267
newRoundNbVotes == 0
12681268
) {
1269-
// Falling back to the current court and dispute kit with default nbVotes.
1269+
// Falling back to the current court and dispute kit with default nbVotes increase.
12701270
newCourtID = _dispute.courtID;
12711271
newDisputeKitID = disputeKitID;
12721272
newRoundNbVotes = (_round.nbVotes * 2) + 1;
12731273
}
12741274
// Ensure compatibility between the next round's court and dispute kit.
12751275
if (!courts[newCourtID].supportedDisputeKits[newDisputeKitID]) {
1276-
// Falling back to `DisputeKitClassic` which is always supported and with default nbVotes.
1276+
// Falling back to `DisputeKitClassic` which is always supported and with default nbVotes increase.
12771277
newDisputeKitID = DISPUTE_KIT_CLASSIC;
12781278
newRoundNbVotes = (_round.nbVotes * 2) + 1;
12791279
}

contracts/src/arbitration/dispute-kits/DisputeKitClassicBase.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,7 @@ abstract contract DisputeKitClassicBase is IDisputeKit, Initializable, UUPSProxi
302302
) internal isActive(_coreDisputeID) {
303303
(, , KlerosCore.Period period, , ) = core.disputes(_coreDisputeID);
304304
if (period != KlerosCore.Period.commit) revert NotCommitPeriod();
305+
if (_voteIDs.length == 0) revert EmptyVoteIDs();
305306
if (_commit == bytes32(0)) revert EmptyCommit();
306307

307308
Dispute storage dispute = disputes[coreDisputeIDToLocal[_coreDisputeID]];

contracts/src/libraries/SortitionTrees.sol

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ library SortitionTrees {
4343

4444
/// @notice Draw an ID from a tree using a number.
4545
///
46-
/// @dev This function reverts if the sum of all values in the tree is 0.
47-
/// `O(k * log_k(n))` where
46+
/// @dev `O(k * log_k(n))` where
4847
/// `k` is the maximum number of children per node in the tree,
4948
/// and `n` is the maximum number of nodes ever appended.
5049
///

0 commit comments

Comments
 (0)