Skip to content

Commit 905def3

Browse files
committed
Handle null value
1 parent 1440db4 commit 905def3

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@kla/digits",
3-
"version": "0.5.0",
3+
"version": "0.5.1",
44
"repository": "https://github.com/kla/digits",
55
"type": "module",
66
"main": "./dist/digits.umd.mjs",

src/Digits.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<template>
2-
<span :class="classes" :title="number.value.toString()">
2+
<span :class="classes" :title="value ? value.toString() : ''">
33
<span v-if="value != null && value != undefined">{{ formatted }}</span>
44
<span v-if="number.unitAbbreviation" :class="`fm-abbrev fm-${number.unit}`">{{ number.unitAbbreviation }}</span>
55
</span>
@@ -36,7 +36,7 @@ const props = withDefaults(defineProps<Props>(), {
3636
const classes = computed(() => {
3737
const classes = [ 'fm' ]
3838
39-
if (parseFloat(props.value.toString()) < 0) classes.push('fm-negative')
39+
if (props.value && parseFloat(props.value.toString()) < 0) classes.push('fm-negative')
4040
if (props.colored && number.value.number != '-0.00' && number.value.number != '0.00') classes.push('fm-colored')
4141
return classes.join(' ')
4242
})

src/test/Digits.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ describe('Digits', () => {
3131
it('accepts a showSymbol option', () => render(Digits, { props: { value: 1_500_000, showSymbol: false } }).getByText('1,500,000.00'))
3232
it('accepts a subscriptDecimals option', () => render(Digits, { props: { value: 0.000001, maxDecimals: 6, subscriptmaxDecimals: 2 } }).getByText('$0.0₅1'))
3333
it('handles -0.00', () => render(Digits, { props: { value: '-0.00' } }).getByText('$0.00'))
34-
it('handles 0', () => {
35-
render(Digits, { props: { value: 0 } }).getByText('$0.00')
36-
})
34+
it('handles 0', () => render(Digits, { props: { value: 0 } }).getByText('$0.00'))
35+
it('handles null value', () => render(Digits, { props: { value: null } }))
36+
it('handles undefined value', () => render(Digits, { props: { } }))
3737
})

0 commit comments

Comments
 (0)