Skip to content

Commit d023d6a

Browse files
committed
Fix flaky Test IndexServiceTests.testBaseAsyncTaskWithFixedIntervalEnabledAndLongerRefresh (opensearch-project#20077)
Signed-off-by: kkewwei <[email protected]>
1 parent 69eb803 commit d023d6a

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

server/src/test/java/org/opensearch/index/IndexServiceTests.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -748,14 +748,14 @@ protected void runInternal() {
748748
}
749749
) {
750750
// In zero state, we have a random sleep duration
751-
long sleepDurationMs = task.getSleepDuration().millis();
752-
assertTrue(sleepDurationMs > 0);
751+
long sleepDurationNanos = task.getSleepDuration().nanos();
752+
assertTrue(sleepDurationNanos > 0);
753753
task.run();
754754
latch.await();
755755
// Since we have refresh taking up 2s, then the next refresh should have sleep duration of 3s. Here we check
756756
// the sleep duration to be non-zero since the sleep duration is calculated dynamically.
757-
sleepDurationMs = task.getSleepDuration().millis();
758-
assertTrue(sleepDurationMs > 0);
757+
sleepDurationNanos = task.getSleepDuration().nanos();
758+
assertTrue(sleepDurationNanos > 0);
759759
assertEquals(0, latch.getCount());
760760
indexService.close("test", false);
761761
assertBusy(() -> { assertEquals(TimeValue.ZERO, task.getSleepDuration()); });
@@ -783,14 +783,14 @@ protected void runInternal() {
783783
}
784784
) {
785785
// In zero state, we have a random sleep duration
786-
long sleepDurationMs = task.getSleepDuration().millis();
787-
assertTrue(sleepDurationMs > 0);
786+
long sleepDurationNanos = task.getSleepDuration().nanos();
787+
assertTrue(sleepDurationNanos > 0);
788788
task.run();
789789
latch.await();
790790
indexService.close("test", false);
791791
// Since we have refresh taking up 2s and refresh interval as 1s, then the next refresh should happen immediately.
792-
sleepDurationMs = task.getSleepDuration().millis();
793-
assertEquals(0, sleepDurationMs);
792+
sleepDurationNanos = task.getSleepDuration().nanos();
793+
assertEquals(0, sleepDurationNanos);
794794
assertEquals(0, latch.getCount());
795795
}
796796
}

0 commit comments

Comments
 (0)