Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need vs_redist.64.exe #1270

Open
kelson42 opened this issue Dec 9, 2024 · 3 comments
Open

Do we still need vs_redist.64.exe #1270

kelson42 opened this issue Dec 9, 2024 · 3 comments
Assignees
Milestone

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Dec 9, 2024

I see this is still part of https://download.kiwix.org/nightly/2024-12-09/kiwix-desktop_windows_x64_2024-12-09.zip. Having to use this is really a burden (in case of a portable app, this is almost a bug), do we still need it?

@kelson42 kelson42 added this to the 2.4.0 milestone Dec 9, 2024
@veloman-yunkan
Copy link
Collaborator

..., do we still need it?

Why don't you just delete that file from a kiwix-desktop package and try to run kiwix-desktop on a Windows machine without Visual Studio installed?

@kelson42
Copy link
Collaborator Author

At the end, whatever the result, it won't change much as I primarly want to understand the scenario where we might need it.

@kelson42 kelson42 modified the milestones: 2.4.0, 2.5.0 Dec 10, 2024
@y1111
Copy link

y1111 commented Dec 20, 2024

..., do we still need it?

Why don't you just delete that file from a kiwix-desktop package and try to run kiwix-desktop on a Windows machine without Visual Studio installed?

well . i deleted the file and it works normally. but there is vs2015 in the machine. but u mean that if there in not any vs in the machine it wil l not work is it ?

and actually, if this redist file is all that a win pc need to run, so the pc can have just this file available and use foir all software that needs right ? and it need to be in path ? so one can just move this file for like system32 folder and leave it there and done.

so a fix could be: when open if fail for not having vs , give and error :"failed no vs" and "would u like to download" , and then download and save in the folder .

@kelson42 kelson42 pinned this issue Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants