You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@BPerlakiH Please secure that whatever the libkiwix returns true or false, this is handled properly here and the app does not crash. For the rest, kiwix/libkiwix#1099 should be fixed.
Make sure that inputing invalid data into the OPDSParse function is handled correctly.
We already have a unit test case for this, but so far it has been disabled, with the comment:
"Requires work in dependency to resolve the issue."
As libkiwix is always returning true, regardless of the input, this might cause some issues, as invalid input handling is not in place.
On the reader side:
kiwix-apple/Model/OPDSParser/OPDSParser.swift
Lines 27 to 31 in 86a037c
Whereas underneath that we have:
kiwix-apple/Model/OPDSParser/OPDSParser.mm
Lines 42 to 51 in 86a037c
Related libkiwix ticket: kiwix/libkiwix#1099
The text was updated successfully, but these errors were encountered: