Add tests for count()

Author: kitar

src/Kitar/Dynamodb/Query/Builder.php

@@ -399,7 +399,7 @@ public function count($columns = '*') {
         // reset columns selection
         $this->select([])->selectAttributes('COUNT');
 
-        return (int) $this->process('clientQuery', 'processCount');
+        return $this->process('clientQuery', 'processCount');
     }
 
     /**

src/Kitar/Dynamodb/Query/Processor.php

@@ -52,9 +52,11 @@ public function processCount(Result $awsResponse, $modelClass = null) {
             return $response;
         }
 
-        if (! empty($response['Count'])) {
-            return $response['Count'];
+        if (! empty($response['Count']) && is_numeric($response['Count'])) {
+            return (int) $response['Count'];
         }
+
+        return null;
     }
 
     public function processSingleItem(Result $awsResponse, $modelClass = null)

tests/Query/BuilderTest.php

@@ -1227,4 +1227,77 @@ public function it_returns_prefixed_builder()
             $result['params']['TableName']
         );
     }
+
+    /** @test */
+    public function it_can_process_count_without_conditions()
+    {
+        $method = 'clientQuery';
+        $params = [
+            'TableName' => 'ProductCatalog',
+            'Select' => 'COUNT'
+        ];
+        $processor = 'processCount';
+
+        $query = $this->newQuery('ProductCatalog')->count();
+
+        $this->assertEquals($method, $query['method']);
+        $this->assertEquals($params, $query['params']);
+        $this->assertEquals($processor, $query['processor']);
+    }
+
+    /** @test */
+    public function it_can_process_count_with_key_condition()
+    {
+        $method = 'clientQuery';
+        $params = [
+            'TableName' => 'ProductCatalog',
+            'Select' => 'COUNT',
+            'KeyConditionExpression' => '#1 = :1',
+            'ExpressionAttributeNames' => [
+                '#1' => 'Id'
+            ],
+            'ExpressionAttributeValues' => [
+                ':1' => [
+                    'N' => '101'
+                ]
+            ]
+        ];
+        $processor = 'processCount';
+
+        $query = $this->newQuery('ProductCatalog')
+                      ->keyCondition('Id', '=', 101)
+                      ->count();
+
+        $this->assertEquals($method, $query['method']);
+        $this->assertEquals($params, $query['params']);
+        $this->assertEquals($processor, $query['processor']);
+    }
+
+    /** @test */
+    public function it_can_process_count_with_filter()
+    {
+        $method = 'clientQuery';
+        $params = [
+            'TableName' => 'Thread',
+            'Select' => 'COUNT',
+            'FilterExpression' => '#1 = :1',
+            'ExpressionAttributeNames' => [
+                '#1' => 'ForumName'
+            ],
+            'ExpressionAttributeValues' => [
+                ':1' => [
+                    'S' => 'Amazon DynamoDB'
+                ]
+            ]
+        ];
+        $processor = 'processCount';
+
+        $query = $this->newQuery('Thread')
+                      ->filter('ForumName', '=', 'Amazon DynamoDB')
+                      ->count();
+
+        $this->assertEquals($method, $query['method']);
+        $this->assertEquals($params, $query['params']);
+        $this->assertEquals($processor, $query['processor']);
+    }
 }

tests/Query/ProcessorTest.php

@@ -28,6 +28,9 @@ class ProcessorTest extends TestCase
         'batch_get_items_processed' => '{"Responses":{"Thread":[{"Replies":0,"Answered":0,"Views":0,"ForumName":"Amazon DynamoDB","Subject":"DynamoDB Thread 1"},{"Replies":0,"Answered":0,"Views":0,"ForumName":"Amazon DynamoDB","Subject":"DynamoDB Thread 2"}]},"UnprocessedKeys":[],"@metadata":{"statusCode":200,"effectiveUri":"https:\/\/dynamodb.ap-northeast-1.amazonaws.com","transferStats":{"http":[[]]}}}',
         'batch_get_items_empty_result' => '{"Responses":{"Thread":[]},"UnprocessedKeys":[],"@metadata":{"statusCode":200,"effectiveUri":"https:\/\/dynamodb.ap-northeast-1.amazonaws.com","transferStats":{"http":[[]]}}}',
         'batch_get_items_empty_processed' => '{"Responses":{"Thread":[]},"UnprocessedKeys":[],"@metadata":{"statusCode":200,"effectiveUri":"https:\/\/dynamodb.ap-northeast-1.amazonaws.com","transferStats":{"http":[[]]}}}',
+        'count_result_with_valid_count' => '{"Count":5,"ScannedCount":5,"@metadata":{"statusCode":200,"effectiveUri":"https:\/\/dynamodb.ap-northeast-1.amazonaws.com"}}',
+        'count_result_without_count' => '{"ScannedCount":0,"@metadata":{"statusCode":200,"effectiveUri":"https:\/\/dynamodb.ap-northeast-1.amazonaws.com"}}',
+        'count_result_with_zero_count' => '{"Count":0,"ScannedCount":0,"@metadata":{"statusCode":200,"effectiveUri":"https:\/\/dynamodb.ap-northeast-1.amazonaws.com"}}',
     ];
 
     protected function setUp() :void
@@ -161,4 +164,34 @@ public function it_can_convert_batch_get_results_to_model_instance()
         ], $item->toArray());
         $this->assertEquals(200, $item->meta()['@metadata']['statusCode']);
     }
+
+    /** @test */
+    public function it_can_process_count_result_with_valid_count()
+    {
+        $awsResult = new Result(json_decode($this->mocks['count_result_with_valid_count'], true));
+
+        $count = $this->processor->processCount($awsResult, User::class);
+
+        $this->assertEquals(5, $count);
+    }
+
+    /** @test */
+    public function it_can_process_count_result_with_no_count()
+    {
+        $awsResult = new Result(json_decode($this->mocks['count_result_without_count'], true));
+
+        $count = $this->processor->processCount($awsResult, User::class);
+
+        $this->assertNull($count);
+    }
+
+    /** @test */
+    public function it_can_process_count_result_with_zero_count()
+    {
+        $awsResult = new Result(json_decode($this->mocks['count_result_with_zero_count'], true));
+
+        $count = $this->processor->processCount($awsResult, User::class);
+
+        $this->assertEquals(0, $count);
+    }
 }