Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realize searching group with tag #231

Open
triszt4n opened this issue May 1, 2020 · 1 comment
Open

Realize searching group with tag #231

triszt4n opened this issue May 1, 2020 · 1 comment
Labels
enhancement New feature or request UI / UX Affects the UI and UX of app

Comments

@triszt4n
Copy link
Member

triszt4n commented May 1, 2020

Idea:

In groups menu, user should be able to search groups containing the tag from a newly implemented search bar. (copy search bar from here: https://bulma.io/documentation/components/panel/) See issue #230 before this one.

Reason:

Migth be useful for finding study mates.

@triszt4n triszt4n added enhancement New feature or request UI / UX Affects the UI and UX of app labels May 1, 2020
@OmTheTurtle
Copy link
Member

OmTheTurtle commented Jun 23, 2020

I was thinking about this lately. I think it could be great if people could search for group name (and description) too. and I see two way of implementing searching:

  • Dedicated input fields for name, tags and description.
  • One unified input field with possibly using fuzzy search

If we want fuzzy search, looking at Objection.js' documentation, we can't use pagination.

On the front-end, I think it's inevitable to perform hard reload when the user hits the search button, mainly because we use pagination and server-rendered HTML (or at least it looks like it'd need significant front-end JS code to implement it the right way).

Either way we'll definitely need to create indices in the fields we want to search for in groups table.

Additionally, having a date range picker makes a lot of sense, since people probably don't want to see very old groups.
(More additionally, having a room selector makes sense too, but we can make a dedicated page for this that's available from the main page.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI / UX Affects the UI and UX of app
Projects
None yet
Development

No branches or pull requests

2 participants