Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move group settings to modal #251

Open
6 of 7 tasks
TomRomeo opened this issue Feb 7, 2024 · 0 comments
Open
6 of 7 tasks

Move group settings to modal #251

TomRomeo opened this issue Feb 7, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request Frontend Issues related to the Frontend good first issue Good for newcomers Refactor Issues regarding Refactoring
Milestone

Comments

@TomRomeo
Copy link
Contributor

TomRomeo commented Feb 7, 2024

Description

As we want to move away from different tabs in subpages, we have to change the position for settings of groups.
Instead of the settings page that we had before, the settings should now be opened in a modal.

Steps

  • Add settings icon to the group page
  • Refactor CreateGroupModal to GroupModal
  • Accept a group entity as optional input
  • Conditionally change modal title and button
  • Add groupType setting to the modal
  • Conditionally add the leave and delete button to the modal
  • Remove Settings from TabBar on the groups page
@TomRomeo TomRomeo added enhancement New feature or request Frontend Issues related to the Frontend Refactor Issues regarding Refactoring labels Feb 7, 2024
@Julian702 Julian702 added this to the v1.0.0 milestone Feb 13, 2024
@Julian702 Julian702 added the good first issue Good for newcomers label Feb 15, 2024
@JJthere JJthere self-assigned this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Frontend Issues related to the Frontend good first issue Good for newcomers Refactor Issues regarding Refactoring
Projects
None yet
Development

No branches or pull requests

3 participants