refactor specs

Author: khusnetdinov

.gitignore

@@ -1,3 +1,4 @@
+/.idea
 /_build
 /cover
 /deps

lib/test_helpers.ex

@@ -0,0 +1,27 @@
+defmodule Loki.TestHelpers do
+  import ExUnit.CaptureIO
+  import Loki.Directory
+  import Loki.File
+
+  @tests_directory "temp"
+
+  def prepare_tests() do
+    if exists_directory?(@tests_directory) do
+      capture_io(fn -> remove_directory(@tests_directory) end)
+    end
+
+    create_directory_silently(@tests_directory)
+  end
+
+  def create_directory_silently(dir_name) do
+    capture_io(fn -> create_directory("#{@tests_directory}/#{dir_name}") end)
+  end
+
+  def create_file_silently(file_name) do
+    capture_io(fn -> create_file("#{@tests_directory}/#{file_name}") end)
+  end
+
+  def create_file_silently(file_name, content) do
+    capture_io(fn -> create_file("#{@tests_directory}/#{file_name}", content) end)
+  end
+end

test/loki/cmd_test.exs

@@ -20,6 +20,7 @@ defmodule Loki.CmdTest do
 
     test "#format_output" do
       {test_user, _} = System.cmd("whoami", [])
+
       assert capture_io(fn ->
         format_output(System.cmd("whoami", []))
       end) == "\n\e[33m#{test_user}\e[0m\n"

test/loki/directory_test.exs

@@ -2,6 +2,7 @@ defmodule Loki.DirectoryTest do
   use ExUnit.Case, async: true
 
   import Loki.Directory
+  import Loki.TestHelpers
   import ExUnit.CaptureIO
 
 
@@ -17,15 +18,15 @@ defmodule Loki.DirectoryTest do
     end
 
     test "#copy_directory" do
-      capture_io(fn -> create_directory("temp/copy_dir") end)
+      create_directory_silently("copy_dir")
 
       assert capture_io(fn ->
         copy_directory("temp/copy_dir", "temp/copied_dir")
       end) == "\e[32m *      copy \e[0mtemp/copy_dir\e[32m to \e[0mtemp/copied_dir\e[0m\n"
     end
 
     test "#remove_directory" do
-      capture_io(fn -> create_directory("temp/remove") end)
+      create_directory_silently("remove")
 
       assert capture_io(fn ->
         remove_directory("temp/remove")

test/loki/file_manipulation_test.exs

@@ -1,76 +1,70 @@
 defmodule Loki.FileManipulationTest do
   use ExUnit.Case, async: true
 
-  import Loki.File
-  import Loki.Directory
   import Loki.FileManipulation
+  import Loki.TestHelpers
   import ExUnit.CaptureIO
 
 
-  setup_all do
-    create_directory("temp")
-    :ok
-  end
-
   describe "FileManipulation" do
     test "#append_to_file" do
-      capture_io(fn -> create_file("temp/append") end)
+      create_file_silently("append")
 
       assert capture_io(fn ->
         append_to_file("temp/append", "appended")
       end) == "\e[32m *    append \e[0mtemp/append\e[0m\n"
     end
 
     test "#prepend_to_file" do
-      capture_io(fn -> create_file("temp/prepend") end)
+      create_file_silently("prepend")
 
       assert capture_io(fn ->
         prepend_to_file("temp/prepend", "prepended")
       end) == "\e[32m *   prepend \e[0mtemp/prepend\e[0m\n"
     end
 
     test "#remove_from_file" do
-      capture_io(fn -> create_file("temp/remove", "remove") end)
+      create_file_silently("remove", "remove")
 
       assert capture_io(fn ->
         remove_from_file("temp/remove", "remove")
       end) == "\e[32m *    remove \e[0mtemp/remove\e[0m\n"
     end
 
     test "#inject_into_file" do
-      capture_io(fn -> create_file("temp/inject", "line") end)
+      create_file_silently("inject", "line")
 
       assert capture_io(fn ->
         inject_into_file("temp/inject", "injected", :after, "line")
       end) == "\e[32m *    inject \e[0mtemp/inject\e[0m\n"
     end
 
     test "#replace_in_file" do
-      capture_io(fn -> create_file("temp/replace", "replace") end)
+      create_file_silently("replace", "replace")
 
       assert capture_io(fn ->
         replace_in_file("temp/replace", "replaced", "replace")
       end) == "\e[32m *   replace \e[0mtemp/replace\e[0m\n"
     end
 
     test "#comment_in_file" do
-      capture_io(fn -> create_file("temp/comment", "comment") end)
+      create_file_silently("comment", "comment")
 
       assert capture_io(fn ->
         comment_in_file("temp/comment", "comment")
       end) == "\e[32m *  comment \e[0mtemp/comment\e[0m\n"
     end
 
     test "#uncomment_in_file" do
-      capture_io(fn -> create_file("temp/uncomment", "# uncomment") end)
+      create_file_silently("uncomment", "# uncomment")
 
       assert capture_io(fn ->
         comment_in_file("temp/uncomment", "# uncomment")
       end) == "\e[32m *  comment \e[0mtemp/uncomment\e[0m\n"
     end
 
     test "#remove_comments_in_file" do
-      capture_io(fn -> create_file("temp/remove_all_comments", "# comment\n # comment") end)
+      create_file_silently("remove_all_comments", "# comment\n # comment")
 
       assert capture_io(fn ->
         remove_comments_in_file("temp/remove_all_comments")

test/loki/file_test.exs

@@ -2,13 +2,9 @@ defmodule Loki.FileTest do
   use ExUnit.Case, async: true
 
   import Loki.File
-  import Loki.Directory
+  import Loki.TestHelpers
   import ExUnit.CaptureIO
 
-  setup_all do
-    create_directory("temp")
-    :ok
-  end
 
   describe "File" do
     test "#create_file" do
@@ -18,39 +14,39 @@ defmodule Loki.FileTest do
     end
 
     test "#create_file_force" do
-      capture_io(fn -> create_file("temp/force") end)
+      create_file_silently("force")
 
       assert capture_io(fn ->
         create_file_force("temp/force")
       end) == "\e[33m *     force \e[0mtemp/force\e[0m\n"
     end
 
     test "#copy_file" do
-      capture_io(fn -> create_file("temp/copy") end)
+      create_file_silently("copy")
 
       assert capture_io(fn ->
         copy_file("temp/copy", "temp/copied")
       end) == "\e[32m *      copy \e[0mtemp/copy\e[32m to \e[0mtemp/copied\e[0m\n"
     end
 
     test "#create_link" do
-      capture_io(fn -> create_file("temp/link") end)
+      create_file_silently("link")
 
       assert capture_io(fn ->
         create_link("temp/link", "temp/linked")
       end) == "\e[32m *      link \e[0mtemp/link\e[32m to \e[0mtemp/linked\e[0m\n"
     end
 
     test "#remove_file" do
-      capture_io(fn -> create_file("temp/remove") end)
+      create_file_silently("remove")
 
       assert capture_io(fn ->
         remove_file("temp/remove")
       end) == "\e[32m *    remove \e[0mtemp/remove\e[0m\n"
     end
 
     test "#rename_file" do
-      capture_io(fn -> create_file("temp/rename") end)
+      create_file_silently("rename")
 
       assert capture_io(fn ->
         rename("temp/rename", "temp/renamed")

test/test_helper.exs

@@ -1,7 +1,2 @@
-import Loki.Directory
-
-temp = "temp"
-
-if exists_directory?(temp), do: remove_directory(temp)
-
+Loki.TestHelpers.prepare_tests()
 ExUnit.start()