Skip to content

Commit bc4e512

Browse files
committed
Fixed #440 - Upgrade ITF Framework Maven Version minimum to 3.8.1
1 parent 1f781b6 commit bc4e512

File tree

4 files changed

+6
-9
lines changed

4 files changed

+6
-9
lines changed

itf-documentation/src/main/asciidoc/release-notes/_release-notes-0.14.0.adoc

+2-1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
:issue-453: https://github.com/khmarbaise/maven-it-extension/issues/453[Fixed #453]
3232
:issue-455: https://github.com/khmarbaise/maven-it-extension/issues/455[Fixed #455]
3333
:issue-456: https://github.com/khmarbaise/maven-it-extension/issues/456[Fixed #456]
34+
:issue-440: https://github.com/khmarbaise/maven-it-extension/issues/440[Fixed #440]
3435

3536
:release_0_14_0: https://github.com/khmarbaise/maven-it-extension/milestone/14
3637

@@ -56,7 +57,7 @@
5657
* {issue-420} - Upgrade assertj-bom to 3.25.0
5758
* {issue-451} - Upgrade assertj-bom to 3.25.1
5859
* {issue-453} - Upgrade memoryfilesystem to 2.8.0
59-
* {issue-???} - ?
60+
* {issue-440} - Upgrade ITF Framework Maven Version minimum to 3.8.1
6061

6162
*Build Improvements*
6263

itf-examples/src/test/java/com/soebes/itf/examples/goals/MetaAnnotationGoalIT.java

-2
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ void clean_verify(MavenExecutionResult result) {
3939
.info()
4040
.containsSubsequence(
4141
"Scanning for projects...",
42-
"-------------------< com.soebes.katas:kata-fraction >-------------------",
43-
"--------------------------------[ jar ]---------------------------------",
4442
"--- clean:3.3.2:clean (default-clean) @ kata-fraction ---",
4543
"--- enforcer:3.4.1:enforce (enforce-maven) @ kata-fraction ---",
4644
"--- jacoco:0.8.11:prepare-agent (default) @ kata-fraction ---",

itf-failure-plugin/src/test/java/com/soebes/itf/maven/plugin/failure/FailureIT.java

+3-5
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@
3030
@MavenJupiterExtension
3131
class FailureIT {
3232

33-
private static final String SEPARATOR_LINE = "------------------------------------------------------------------------";
34-
35-
@MavenTest
33+
@MavenTest
3634
@DisplayName("The basic configuration should result in a successful build.")
3735
void basic_configuration(MavenExecutionResult project) {
3836
assertThat(project).isSuccessful().out().warn().contains("Neither executionException nor failureException has been set.");
@@ -42,7 +40,7 @@ void basic_configuration(MavenExecutionResult project) {
4240
void fail_with_mojo_execution_exception(MavenExecutionResult result) {
4341
assertThat(result).isFailure();
4442

45-
assertThat(result).out().info().containsSequence(SEPARATOR_LINE, "BUILD FAILURE", SEPARATOR_LINE);
43+
assertThat(result).out().info().containsSequence("BUILD FAILURE");
4644

4745
//TODO: Is there a simpler way to do this? Can we somehow create better support for that?
4846
assertThat(result).out().error().filteredOn(s -> s.startsWith("Failed to execute goal ")).satisfies(s -> {
@@ -58,7 +56,7 @@ void fail_with_mojo_execution_exception(MavenExecutionResult result) {
5856
void fail_with_mojo_failure_exception(MavenExecutionResult result) {
5957
assertThat(result).isFailure();
6058

61-
assertThat(result).out().info().containsSequence(SEPARATOR_LINE, "BUILD FAILURE", SEPARATOR_LINE);
59+
assertThat(result).out().info().containsSequence("BUILD FAILURE");
6260

6361
//TODO: Is there a simpler way to do this? Can we somehow create better support for that?
6462
assertThat(result).out().error().filteredOn(s -> s.startsWith("Failed to execute goal ")).satisfies(s -> {

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@
117117
<dependency>
118118
<groupId>org.apache.maven</groupId>
119119
<artifactId>maven-model</artifactId>
120-
<version>3.2.5</version>
120+
<version>3.8.1</version>
121121
</dependency>
122122
<dependency>
123123
<groupId>org.apache.maven.resolver</groupId>

0 commit comments

Comments
 (0)