Add comparison for periods in ICAL.Time::compare

Author: kewisch

lib/ical/time.js

@@ -5,6 +5,7 @@
 
 import Timezone from "./timezone.js";
 import Duration from "./duration.js";
+import Period from "./period.js";
 import design from "./design.js";
 import TimezoneService from "./timezone_service.js";
 import { strictParseInt, trunc, pad2 } from "./helpers.js";
@@ -965,18 +966,22 @@ class Time {
   }
 
   /**
-   * Compares the ICAL.Time instance with another one.
+   * Compares the ICAL.Time instance with another one, or a period.
    *
-   * @param {ICAL.Duration} aOther        The instance to compare with
-   * @return {Number}                     -1, 0 or 1 for less/equal/greater
+   * @param {ICAL.Time|ICAL.Period} aOther        The instance to compare with
+   * @return {Number}                             -1, 0 or 1 for less/equal/greater
    */
   compare(other) {
-    let a = this.toUnixTime();
-    let b = other.toUnixTime();
+    if (other instanceof Period) {
+      return -1 * other.compare(this);
+    } else {
+      let a = this.toUnixTime();
+      let b = other.toUnixTime();
 
-    if (a > b) return 1;
-    if (b > a) return -1;
-    return 0;
+      if (a > b) return 1;
+      if (b > a) return -1;
+      return 0;
+    }
   }
 
   /**

test/time_test.js

@@ -1606,6 +1606,28 @@ suite('icaltime', function() {
       assert.equal(a.compare(b), 1);
       assert.equal(b.compare(a), -1);
     });
+
+    test("compare with period", function() {
+      let periodbefore = ICAL.Period.fromData({
+        start: Time.fromString("1970-01-02T03:04:03Z"),
+        end: Time.fromString("1970-01-02T03:04:04Z")
+      });
+      let periodat = ICAL.Period.fromData({
+        start: Time.fromString("1970-01-02T03:04:05Z"),
+        end: Time.fromString("1970-01-02T03:04:05Z")
+      });
+      let periodafter = ICAL.Period.fromData({
+        start: Time.fromString("1970-01-02T03:04:06Z"),
+        end: Time.fromString("1970-01-02T03:04:07Z")
+      });
+
+
+      let dt = Time.fromString('1970-01-02T03:04:05Z');
+
+      assert.equal(dt.compare(periodbefore), 1);
+      assert.equal(dt.compare(periodat), 0);
+      assert.equal(dt.compare(periodafter), -1);
+    });
   });
 
   test('cache cleared', function() {