Skip to content

Minor logging issue: "Appending request" log spam #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AndyKilpatrick opened this issue Mar 12, 2023 · 0 comments · May be fixed by #921
Open

Minor logging issue: "Appending request" log spam #685

AndyKilpatrick opened this issue Mar 12, 2023 · 0 comments · May be fixed by #921
Labels
enhancement

Comments

@AndyKilpatrick
Copy link

AndyKilpatrick commented Mar 12, 2023 •
edited
Loading

With v4.2.1 I'm seeing a lot of (incorrect I think) "Appending request" logs - from code inspection I think this log should be moved down to https://github.com/kevin1024/vcrpy/blob/master/vcr/cassette.py#L252 after the previous return statements.
matthiasschaub added a commit to matthiasschaub/vcrpy that referenced this issue Apr 30, 2025
@matthiasschaub
only log message if response is appended
055ec6b 
Closes: kevin1024#685
@matthiasschaub matthiasschaub linked a pull request Apr 30, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

only log message if response is appended matthiasschaub/vcrpy
2 participants
@hartwork @AndyKilpatrick