fix(core): Continue WaitFor loop if tasks are not failed

close #6031

Author: Skraye

core/src/main/java/io/kestra/plugin/core/flow/WaitFor.java

@@ -209,7 +209,7 @@ public boolean childTaskRunExecuted(Execution execution, TaskRun parentTaskRun)
             .stream()
             .filter(t -> t.getParentTaskRunId() != null
                 && t.getParentTaskRunId().equals(parentTaskRun.getId())
-                && t.getState().isSuccess()
+                && t.getState().isTerminated()
             ).count() == tasks.size();
 
     }

core/src/test/java/io/kestra/plugin/core/flow/WaitForCaseTest.java

@@ -61,4 +61,11 @@ public void waitforMultipleTasksFailed() throws TimeoutException, QueueException
         assertThat(execution.getState().getCurrent(), is(State.Type.FAILED));
         assertThat(execution.getTaskRunList().getLast().attemptNumber(), is(1));
     }
+
+    public void waitForChildTaskWarning() throws TimeoutException, QueueException {
+        Execution execution = runnerUtils.runOne(null, "io.kestra.tests", "waitfor-child-task-warning");
+
+        assertThat(execution.getState().getCurrent(), is(State.Type.FAILED));
+        assertThat(execution.getTaskRunList().getLast().attemptNumber(), greaterThan(1));
+    }
 }

core/src/test/resources/flows/valids/waitfor-child-task-warning.yaml

@@ -0,0 +1,30 @@
+id: waitfor-child-task-warning
+namespace: io.kestra.tests
+
+tasks:
+  - id: loop
+    type: io.kestra.plugin.core.flow.WaitFor
+    condition: "{{ outputs.check_migration_task.vars['status'] == 'FINISHED' }}"
+    failOnMaxReached: true
+    checkFrequency:
+      interval: PT5S
+      maxDuration: PT10S
+    tasks:
+
+      ## forcing a Warning
+      - id: allow_failure
+        type: io.kestra.plugin.scripts.shell.Commands
+        taskRunner:
+          type: io.kestra.plugin.core.runner.Process
+        allowFailure: true
+        commands:
+          - exit 1
+
+      - id: check_migration_task
+        type: io.kestra.plugin.scripts.shell.Commands
+        taskRunner:
+          type: io.kestra.plugin.scripts.runner.docker.Docker
+          entryPoint: []
+        containerImage: "ubuntu:latest"
+        commands:
+          - "echo '::{\"outputs\":{\"status\": \"INPROGRESS\"}}::'"