Land rapid7#18294, pick up netifaces updates, improve error catching

Author: sjanusz-r7

Gemfile.lock

@@ -308,7 +308,7 @@ GEM
     net-smtp (0.3.3)
       net-protocol
     net-ssh (7.1.0)
-    network_interface (0.0.2)
+    network_interface (0.0.4)
     nexpose (7.3.0)
     nio4r (2.5.9)
     nokogiri (1.14.5)

lib/msf/core/opt_address_local.rb

@@ -10,7 +10,12 @@ module Msf
 ###
 class OptAddressLocal < OptAddress
   def interfaces
-    NetworkInterface.interfaces || []
+    begin
+      NetworkInterface.interfaces || []
+    rescue NetworkInterface::Error => e
+      elog(e)
+      []
+    end
   end
 
   def normalize(value)

spec/lib/msf/core/opt_address_local_spec.rb

@@ -94,4 +94,17 @@
       end
     end
   end
+  describe '#interfaces' do
+    context 'getting errors' do
+      before(:each) do
+        allow(NetworkInterface).to receive(:interfaces).and_raise(NetworkInterface::Error)
+      end
+
+      it 'rescues and returns an empty array' do
+        expect(required_opt).to receive(:elog).with(an_instance_of(NetworkInterface::Error))
+        result = required_opt.interfaces()
+        expect(result).to eq([])
+      end
+    end
+  end
 end