Conversation
roborev: Combined Review (
|
Member
|
looking |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The people-fact origin migration can block startup when an archive has pre-existing foreign-key violations in unrelated tables. Its database-wide
PRAGMA foreign_key_checktreats those older references as failures of the people-fact table rebuild.Check
person_fact_claims,person_fact_claim_evidence, andperson_fact_decisionsinstead. Invalid references in those tables still fail the migration and roll back the rebuild; unrelated archive data remains unchanged.The regression cases cover an unrelated orphan reference, an invalid claim parent, and an invalid evidence-to-claim reference. They also check rollback and restoration of foreign-key enforcement.