From 2e36bcdf291ccef7f1c5accde45f7bceb525471a Mon Sep 17 00:00:00 2001 From: Huong Nguyen Date: Mon, 2 Dec 2024 13:59:38 +0000 Subject: [PATCH 1/4] add deprecation warning for tracking datatsets Signed-off-by: Huong Nguyen --- kedro-datasets/kedro_datasets/tracking/__init__.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/kedro-datasets/kedro_datasets/tracking/__init__.py b/kedro-datasets/kedro_datasets/tracking/__init__.py index 6ea2eee13..081602f6c 100644 --- a/kedro-datasets/kedro_datasets/tracking/__init__.py +++ b/kedro-datasets/kedro_datasets/tracking/__init__.py @@ -4,6 +4,9 @@ import lazy_loader as lazy +import warnings +from kedro_datasets import KedroDeprecationWarning + # https://github.com/pylint-dev/pylint/issues/4300#issuecomment-1043601901 JSONDataset: Any MetricsDataset: Any @@ -15,3 +18,9 @@ "metrics_dataset": ["MetricsDataset"], }, ) + +warnings.warn( + "`tracking.JSONDataset` and `tracking.MetricsDataset` are deprecated. These datasets will be removed in kedro-datasets 7.0.0", + KedroDeprecationWarning, + stacklevel=2, +) From 2fd629ce9560c4f51b2f2daa4f6f92e03c4f4272 Mon Sep 17 00:00:00 2001 From: Huong Nguyen Date: Mon, 2 Dec 2024 14:15:29 +0000 Subject: [PATCH 2/4] update release note Signed-off-by: Huong Nguyen --- kedro-datasets/RELEASE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/kedro-datasets/RELEASE.md b/kedro-datasets/RELEASE.md index bfd273e31..ac9efd99c 100755 --- a/kedro-datasets/RELEASE.md +++ b/kedro-datasets/RELEASE.md @@ -14,6 +14,7 @@ ## Bug fixes and other changes - Implemented Snowflake's (local testing framework)[https://docs.snowflake.com/en/developer-guide/snowpark/python/testing-locally] for testing purposes - Improved the dependency management for Spark-based datasets by refactoring the Spark and Databricks utility functions used across the datasets. +- Add deprecation warning for MetricsTrackingDataset and JSONTrackingDataset. ## Breaking Changes - Demoted `video.VideoDataset` from core to experimental dataset. From 1437286b52c260677af0cbc64a491507773ca2cc Mon Sep 17 00:00:00 2001 From: Huong Nguyen <32060364+Huongg@users.noreply.github.com> Date: Mon, 2 Dec 2024 14:45:13 +0000 Subject: [PATCH 3/4] Update kedro-datasets/RELEASE.md Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Signed-off-by: Huong Nguyen <32060364+Huongg@users.noreply.github.com> --- kedro-datasets/RELEASE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kedro-datasets/RELEASE.md b/kedro-datasets/RELEASE.md index ac9efd99c..fec3a2107 100755 --- a/kedro-datasets/RELEASE.md +++ b/kedro-datasets/RELEASE.md @@ -14,7 +14,7 @@ ## Bug fixes and other changes - Implemented Snowflake's (local testing framework)[https://docs.snowflake.com/en/developer-guide/snowpark/python/testing-locally] for testing purposes - Improved the dependency management for Spark-based datasets by refactoring the Spark and Databricks utility functions used across the datasets. -- Add deprecation warning for MetricsTrackingDataset and JSONTrackingDataset. +- Add deprecation warning for `tracking.MetricsDataset` and `tracking.JSONDataset`. ## Breaking Changes - Demoted `video.VideoDataset` from core to experimental dataset. From 21b8ab0987f4615e96bfd645bce335b46655f91d Mon Sep 17 00:00:00 2001 From: Merel Theisen Date: Mon, 2 Dec 2024 17:40:01 +0000 Subject: [PATCH 4/4] Fix linting Signed-off-by: Merel Theisen --- kedro-datasets/kedro_datasets/tracking/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kedro-datasets/kedro_datasets/tracking/__init__.py b/kedro-datasets/kedro_datasets/tracking/__init__.py index 081602f6c..1b1a5c70d 100644 --- a/kedro-datasets/kedro_datasets/tracking/__init__.py +++ b/kedro-datasets/kedro_datasets/tracking/__init__.py @@ -1,10 +1,10 @@ """Dataset implementations to save data for Kedro Experiment Tracking.""" +import warnings from typing import Any import lazy_loader as lazy -import warnings from kedro_datasets import KedroDeprecationWarning # https://github.com/pylint-dev/pylint/issues/4300#issuecomment-1043601901