From ad67ae9abf6c44f61e1f9aaf85c91c2e5c24d598 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Yolan=20Honor=C3=A9-Roug=C3=A9?= <29451317+Galileo-Galilei@users.noreply.github.com> Date: Thu, 4 Jan 2024 11:07:50 +0100 Subject: [PATCH] fix(datasets): Relax pandas.HDFDataSet dependencies which are broken on Windows (#426) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Relax pandas.HDFDataSet dependencies which are broken on Window (#402) Signed-off-by: Yolan Honoré-Rougé * Update RELEASE.md Signed-off-by: Yolan Honoré-Rougé * Apply suggestions from code review Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> * Update kedro-datasets/setup.py Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> --------- Signed-off-by: Yolan Honoré-Rougé Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> --- kedro-datasets/RELEASE.md | 1 + kedro-datasets/setup.py | 24 ++++++++++++++++-------- 2 files changed, 17 insertions(+), 8 deletions(-) diff --git a/kedro-datasets/RELEASE.md b/kedro-datasets/RELEASE.md index 923821123..f5e9d0396 100755 --- a/kedro-datasets/RELEASE.md +++ b/kedro-datasets/RELEASE.md @@ -1,6 +1,7 @@ # Upcoming Release ## Major features and improvements ## Bug fixes and other changes +* Removed Windows specific conditions in `pandas.HDFDataset` extra dependencies ## Community contributions # Release 2.0.0 diff --git a/kedro-datasets/setup.py b/kedro-datasets/setup.py index 3cb013a21..f908df897 100644 --- a/kedro-datasets/setup.py +++ b/kedro-datasets/setup.py @@ -48,8 +48,7 @@ def _collect_requirements(requires): ], "pandas.HDFDataset": [ PANDAS, - "tables~=3.6.0; platform_system == 'Windows'", - "tables~=3.6; platform_system != 'Windows'", + "tables~=3.6", ], "pandas.JSONDataset": [PANDAS], "pandas.ParquetDataset": [PANDAS, "pyarrow>=6.0"], @@ -66,14 +65,23 @@ def _collect_requirements(requires): } polars_require = { "polars.CSVDataset": [POLARS], - "polars.EagerPolarsDataset": - [ - POLARS, "pyarrow>=4.0", "xlsx2csv>=0.8.0", "deltalake >= 0.6.2" + "polars.GenericDataset": [ + POLARS, + "pyarrow>=4.0", + "xlsx2csv>=0.8.0", + "deltalake >= 0.6.2", ], - "polars.LazyPolarsDataset": - [ + "polars.EagerPolarsDataset": [ + POLARS, + "pyarrow>=4.0", + "xlsx2csv>=0.8.0", + "deltalake >= 0.6.2", + ], + "polars.LazyPolarsDataset": [ # Note: there is no Lazy read Excel option, so we exclude xlsx2csv here. - POLARS, "pyarrow>=4.0", "deltalake >= 0.6.2" + POLARS, + "pyarrow>=4.0", + "deltalake >= 0.6.2", ], } redis_require = {"redis.PickleDataset": ["redis~=4.1"]}