From ab64c20aa4ac7f5b599cfd7ffb03e34c3d035857 Mon Sep 17 00:00:00 2001 From: Merel Theisen <49397448+merelcht@users.noreply.github.com> Date: Fri, 18 Oct 2024 16:19:11 +0100 Subject: [PATCH] ci: Add GH action to check for TSC votes on core dataset changes (#896) * Add GH action to check for TSC votes on core dataset changes * Ignore TSC vote action in gatekeeper * Trigger TSC vote action only on changes in core dataset --------- Signed-off-by: Merel Theisen --- .github/reviewers.json | 36 ++++++++++++++++++++++++++ .github/workflows/check-tsc-vote.yml | 14 ++++++++++ .github/workflows/merge-gatekeeper.yml | 1 + 3 files changed, 51 insertions(+) create mode 100644 .github/reviewers.json create mode 100644 .github/workflows/check-tsc-vote.yml diff --git a/.github/reviewers.json b/.github/reviewers.json new file mode 100644 index 000000000..5a0b265b8 --- /dev/null +++ b/.github/reviewers.json @@ -0,0 +1,36 @@ +{ + "teams": { + "everyone": { + "description": "A team that contains all TSC members.", + "users": [ + "ankatiyar", + "astrojuanlu", + "datajoely", + "deepyaman", + "DimedS", + "Galileo-Galilei", + "Huongg", + "idanov", + "jitu5", + "lrcouto", + "marrrcin", + "merelcht", + "noklam", + "rashidakanchwala", + "ravi-kumar-pilla", + "SajidAlamQB", + "sbrugman", + "stephkaiser", + "tynandebold", + "yetudada" + ] + } + }, + "reviewers": { + "kedro-datasets/kedro_datasets/": { + "description": "Require at least 1/2 TSC approval on new core dataset contributions.", + "teams": ["everyone"], + "requiredApproverCount": 10 + } + } +} diff --git a/.github/workflows/check-tsc-vote.yml b/.github/workflows/check-tsc-vote.yml new file mode 100644 index 000000000..2cc742023 --- /dev/null +++ b/.github/workflows/check-tsc-vote.yml @@ -0,0 +1,14 @@ +name: Required Reviews +on: + pull_request: + paths: + - 'kedro-datasets/kedro_datasets/*' +jobs: + required-reviews: + name: Required Reviews + runs-on: ubuntu-latest + steps: + - name: required-reviewers + uses: theoremlp/required-reviews@v2 + with: + github-token: ${{ secrets.GITHUB_TOKEN }} diff --git a/.github/workflows/merge-gatekeeper.yml b/.github/workflows/merge-gatekeeper.yml index 77ad752de..ac5473240 100644 --- a/.github/workflows/merge-gatekeeper.yml +++ b/.github/workflows/merge-gatekeeper.yml @@ -24,3 +24,4 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} timeout: 2400 interval: 30 + ignored: 'Required Reviews'