From 216a1100fcec48168c3a527ed0ef09fe32cf5492 Mon Sep 17 00:00:00 2001 From: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Date: Mon, 14 Oct 2024 17:18:49 +0100 Subject: [PATCH 1/3] ci(docker): Update error code in e2e test (#888) Update error code in e2e test Signed-off-by: Ankita Katiyar --- kedro-docker/features/docker.feature | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kedro-docker/features/docker.feature b/kedro-docker/features/docker.feature index f3682fd30..2d54de7f3 100644 --- a/kedro-docker/features/docker.feature +++ b/kedro-docker/features/docker.feature @@ -100,7 +100,7 @@ Feature: Docker commands in new projects Scenario: Execute docker run target without building image When I execute the kedro command "docker run" - Then I should get a successful exit code + Then I should get an error exit code And Standard output should contain a message including "Error: Unable to find image `project-dummy` locally." Scenario: Execute docker dive target @@ -118,5 +118,5 @@ Feature: Docker commands in new projects Scenario: Execute docker dive without building image When I execute the kedro command "docker dive" - Then I should get a successful exit code + Then I should get an error exit code And Standard output should contain a message including "Error: Unable to find image `project-dummy` locally." From 1039f35ed0c2958be07c4caf21c8f09f04dffdbb Mon Sep 17 00:00:00 2001 From: Merel Theisen <49397448+merelcht@users.noreply.github.com> Date: Tue, 15 Oct 2024 14:52:25 +0100 Subject: [PATCH 2/3] chore: Update PR template with checkbox for core dataset contribution (#891) * Update PR template with checkbox for core dataset contribution Signed-off-by: Merel Theisen * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: Deepyaman Datta Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> * Fix lint Signed-off-by: Merel Theisen --------- Signed-off-by: Merel Theisen Signed-off-by: Merel Theisen <49397448+merelcht@users.noreply.github.com> Co-authored-by: Deepyaman Datta --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7faf3e035..6723cb70f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -10,3 +10,4 @@ - [ ] Updated the documentation to reflect the code changes - [ ] Added a description of this change in the relevant `RELEASE.md` file - [ ] Added tests to cover my changes +- [ ] Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset) From 44d82457230d7201a045c8cc58b13f0bec118c33 Mon Sep 17 00:00:00 2001 From: Ankita Katiyar <110245118+ankatiyar@users.noreply.github.com> Date: Thu, 17 Oct 2024 11:55:31 +0100 Subject: [PATCH 3/3] ci(datasets): Fix mypy errors (#893) --- kedro-datasets/CONTRIBUTING.md | 2 +- kedro-datasets/README.md | 2 +- kedro-datasets/kedro_datasets/ibis/file_dataset.py | 2 +- kedro-datasets/kedro_datasets/ibis/table_dataset.py | 2 +- kedro-datasets/kedro_datasets/spark/spark_streaming_dataset.py | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/kedro-datasets/CONTRIBUTING.md b/kedro-datasets/CONTRIBUTING.md index 41454f598..8ef5ae52c 100644 --- a/kedro-datasets/CONTRIBUTING.md +++ b/kedro-datasets/CONTRIBUTING.md @@ -89,7 +89,7 @@ def count_truthy(elements: List[Any]) -> int: return sum(1 for elem in elements if elem) ``` -> *Note:* We only accept contributions under the [Apache 2.0](https://opensource.org/licenses/Apache-2.0) license, and you should have permission to share the submitted code. +> *Note:* We only accept contributions under the [Apache 2.0](https://github.com/kedro-org/kedro-plugins/blob/main/LICENSE.md) license, and you should have permission to share the submitted code. ### Branching conventions diff --git a/kedro-datasets/README.md b/kedro-datasets/README.md index aa4531e5b..d84b2bf7f 100644 --- a/kedro-datasets/README.md +++ b/kedro-datasets/README.md @@ -2,7 +2,7 @@ -[![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0) +[![License](https://img.shields.io/badge/license-Apache%202.0-blue.svg)](https://github.com/kedro-org/kedro-plugins/blob/main/LICENSE.md) [![Python Version](https://img.shields.io/badge/python-3.10%20%7C%203.11%20%7C%203.12-blue.svg)](https://pypi.org/project/kedro-datasets/) [![PyPI Version](https://badge.fury.io/py/kedro-datasets.svg)](https://pypi.org/project/kedro-datasets/) [![Code Style: Black](https://img.shields.io/badge/code%20style-black-black.svg)](https://github.com/ambv/black) diff --git a/kedro-datasets/kedro_datasets/ibis/file_dataset.py b/kedro-datasets/kedro_datasets/ibis/file_dataset.py index 11b58bc32..8dc98b4ad 100644 --- a/kedro-datasets/kedro_datasets/ibis/file_dataset.py +++ b/kedro-datasets/kedro_datasets/ibis/file_dataset.py @@ -157,7 +157,7 @@ def hashable(value): config = deepcopy(self._connection_config) backend_attr = config.pop("backend") if config else None - backend = getattr(ibis, backend_attr) + backend = getattr(ibis, str(backend_attr)) cls._connections[key] = backend.connect(**config) return cls._connections[key] diff --git a/kedro-datasets/kedro_datasets/ibis/table_dataset.py b/kedro-datasets/kedro_datasets/ibis/table_dataset.py index 7550e6266..a5744dd22 100644 --- a/kedro-datasets/kedro_datasets/ibis/table_dataset.py +++ b/kedro-datasets/kedro_datasets/ibis/table_dataset.py @@ -159,7 +159,7 @@ def hashable(value): config = deepcopy(self._connection_config) backend_attr = config.pop("backend") if config else None - backend = getattr(ibis, backend_attr) + backend = getattr(ibis, str(backend_attr)) cls._connections[key] = backend.connect(**config) return cls._connections[key] diff --git a/kedro-datasets/kedro_datasets/spark/spark_streaming_dataset.py b/kedro-datasets/kedro_datasets/spark/spark_streaming_dataset.py index b1effc278..294ea35cb 100644 --- a/kedro-datasets/kedro_datasets/spark/spark_streaming_dataset.py +++ b/kedro-datasets/kedro_datasets/spark/spark_streaming_dataset.py @@ -136,7 +136,7 @@ def save(self, data: DataFrame) -> None: ( output_constructor.option("checkpointLocation", checkpoint) .option("path", save_path) - .outputMode(output_mode) + .outputMode(str(output_mode)) .options(**self._save_args or {}) .start() )