Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serde support #17

Closed
zkat opened this issue Aug 13, 2021 · 10 comments
Closed

serde support #17

zkat opened this issue Aug 13, 2021 · 10 comments

Comments

@zkat
Copy link
Member

zkat commented Aug 13, 2021

There should be built-in support for Serialize/Deserialize in this crate.

@berwyn
Copy link

berwyn commented Sep 14, 2021

Hi Kat!

I've never before implemented serde support for a language, but I'd love to take a stab at that here! Would that be amenable to you?

@zkat
Copy link
Member Author

zkat commented Sep 14, 2021

Oh! I should have put a note here. @Lucretiel is already working on a serde-based parser that I expect will replace this one

@berwyn
Copy link

berwyn commented Sep 14, 2021

Ah, sounds good! I'll keep an eye out for that!

@Lucretiel
Copy link

Lucretiel commented Sep 14, 2021

WIP serde implementation is here: https://github.com/lucretiel/kaydle. It's coming along, slowly but surely. It's challenging because serde is very much a structured object / array format, whereas KDL is node-oriented, so I have an opinionated mapping from one to the other. Contributions are welcome, thought there's a lot about my design intent that I haven't written up in the comments yet, so until it hits 1.0 I may be pretty conservative in what I accept if it diverges from that. I work on it (at least) every Sunday at 7pm EST on twitch and I'd be happy to talk at a high level about my design for anyone attending.

@gak
Copy link

gak commented Sep 15, 2021

@Lucretiel FYI your twitch link is broken.

@Lucretiel
Copy link

Fixed, thank you

@zkat
Copy link
Member Author

zkat commented Apr 22, 2022

This is now out of scope for kdl-rs. It's going to be a document-oriented parser.

@pipelight
Copy link

So what should we use for serde support?

@zkat
Copy link
Member Author

zkat commented Aug 21, 2024

@pipelight I guess I should've reopened this one instead, but for reference, serde is back in scope and it would be good to have it working with the kdl v2 release.

Ref: #71

For now, there are no implementations that include serde support directly: you can try using knuffel

@pipelight
Copy link

Thank you! This crate was nowhere to be found!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants