Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgroup clear-stale calls sync() even without quotas enabled #942

Open
buzo-ffm opened this issue Jan 27, 2025 · 0 comments
Open

qgroup clear-stale calls sync() even without quotas enabled #942

buzo-ffm opened this issue Jan 27, 2025 · 0 comments
Labels
Milestone

Comments

@buzo-ffm
Copy link

btrfs qgroup clear-stale calls sync (via btrfs_util_sync_fd()) in cmd/qgroup.c line 2213 before figuring out whether quotas are enabled at all (in line 2219).

This causes unnecessary delays on a system which does not enable quotas, but which uses tools which call this quota-related command. Could you please find out whether quotas are enabled first?

@kdave kdave added the bug label Jan 28, 2025
kdave added a commit that referenced this issue Jan 28, 2025
If qgroups are not enabled the 'clear-stale' command unconditionally
calls sync on the whole filesystem, which is unnecessary and can slow
down the system. Do a check first if qgroups are enabled.

Issue: #942
Signed-off-by: David Sterba <[email protected]>
@kdave kdave added this to the v6.13 milestone Jan 28, 2025
kdave added a commit that referenced this issue Jan 28, 2025
If qgroups are not enabled the 'clear-stale' command unconditionally
calls sync on the whole filesystem, which is unnecessary and can slow
down the system. Do a check first if qgroups are enabled.

Issue: #942
Signed-off-by: David Sterba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants