Skip to content

Commit

Permalink
btrfs-progs: docs: fix incorrect description about compression with O…
Browse files Browse the repository at this point in the history
…_DIRECT

It was reported in https://lore.kernel.org/linux-btrfs/[email protected]/
that compression does not happen on direct io files. This is incorrectly
documented that it works but this is not true. Compression works on
buffered writes and relies on page cache, while direct io avoids that
and takes a different path in code.

[ci skip]

Pull-request: #764
Author: HAN Yuwei <[email protected]>
Signed-off-by: David Sterba <[email protected]>
  • Loading branch information
hanyuwei70 authored and kdave committed Mar 25, 2024
1 parent 41dce59 commit f240b9f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Documentation/ch-compression.rst
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ Compatibility
-------------

Compression is done using the COW mechanism so it's incompatible with
*nodatacow*. Direct IO works on compressed files but will fall back to buffered
writes and leads to recompression. Currently *nodatasum* and compression don't
work together.
*nodatacow*. Direct IO read works on compressed files but will fall back to
buffered writes and leads to no compression even if force compression is set.
Currently *nodatasum* and compression don't work together.

The compression algorithms have been added over time so the version
compatibility should be also considered, together with other tools that may
Expand Down

0 comments on commit f240b9f

Please sign in to comment.