Skip to content

Commit f240b9f

Browse files
hanyuwei70kdave
authored andcommitted
btrfs-progs: docs: fix incorrect description about compression with O_DIRECT
It was reported in https://lore.kernel.org/linux-btrfs/[email protected]/ that compression does not happen on direct io files. This is incorrectly documented that it works but this is not true. Compression works on buffered writes and relies on page cache, while direct io avoids that and takes a different path in code. [ci skip] Pull-request: #764 Author: HAN Yuwei <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent 41dce59 commit f240b9f

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Documentation/ch-compression.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,9 @@ Compatibility
145145
-------------
146146

147147
Compression is done using the COW mechanism so it's incompatible with
148-
*nodatacow*. Direct IO works on compressed files but will fall back to buffered
149-
writes and leads to recompression. Currently *nodatasum* and compression don't
150-
work together.
148+
*nodatacow*. Direct IO read works on compressed files but will fall back to
149+
buffered writes and leads to no compression even if force compression is set.
150+
Currently *nodatasum* and compression don't work together.
151151

152152
The compression algorithms have been added over time so the version
153153
compatibility should be also considered, together with other tools that may

0 commit comments

Comments
 (0)