Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a request to status doesn't include an id field, the service responds with an HTML 500 page #494

Open
MrCreosote opened this issue Nov 18, 2024 · 4 comments
Open

When a request to status doesn't include an id field, the service responds with an HTML 500 page #494

MrCreosote opened this issue Nov 18, 2024 · 4 comments

Comments

@MrCreosote
Copy link
Member

I would at least expect a JSON response

Most other services also don't require an id (which is bad IMO), not sure why it's required here given it's also SDK compiled.

curl -d '{"params":[],"method":"execution_engine2.status"}' https://ci.kbase.us/services/ee2
<html>
  <head>
    <title>Internal Server Error</title>
  </head>
  <body>
    <h1><p>Internal Server Error</p></h1>
    
  </body>
</html>
@bio-boris
Copy link
Collaborator 

11/18/2024 5:06:36 PMTraceback (most recent call last):
11/18/2024 5:06:36 PM  File "/miniconda-latest/lib/python3.10/site-packages/gunicorn/workers/base_async.py", line 55, in handle
11/18/2024 5:06:36 PM    self.handle_request(listener_name, req, client, addr)
11/18/2024 5:06:36 PM  File "/miniconda-latest/lib/python3.10/site-packages/gunicorn/workers/ggevent.py", line 127, in handle_request
11/18/2024 5:06:36 PM    super().handle_request(listener_name, req, sock, addr)
11/18/2024 5:06:36 PM  File "/miniconda-latest/lib/python3.10/site-packages/gunicorn/workers/base_async.py", line 108, in handle_request
11/18/2024 5:06:36 PM    respiter = self.wsgi(environ, resp.start_response)
11/18/2024 5:06:36 PM  File "/kb/module/lib/execution_engine2/execution_engine2Server.py", line 599, in __call__
11/18/2024 5:06:36 PM    ctx["call_id"] = req["id"]
11/18/2024 5:06:36 PMKeyError: 'id'

@bio-boris
Copy link
Collaborator

We suspect that all python services require an ID

@MrCreosote
Copy link
Member Author

The bigger issue for me here is why it's not returning a JSON response with the stacktrace

@MrCreosote
Copy link
Member Author

We suspect that all python services require an ID

if this is true, they should respond with a reasonable error message, which means updating kb_sdk, which means getting kb_sdk_plus in a position where it can be developed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bio-boris @MrCreosote