Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configuration managment #304

Open
MrCreosote opened this issue Feb 4, 2021 · 0 comments
Open

Improve configuration managment #304

MrCreosote opened this issue Feb 4, 2021 · 0 comments
Labels
code cleanup swiffer that crap right up

Comments

@MrCreosote
Copy link
Member

make a class that is responsible for parsing the config file, normalizing arguments (e.g. whitespace -> None), checking arguments are valid (e.g. something that is supposed to be a url looks like a url) including cross validation, and presents the configuration as instance variables on the class instance to other classes. Other classes then have to do much less redundant checking of the config and failures happen immediately on server startup.

@MrCreosote MrCreosote added the code cleanup swiffer that crap right up label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup swiffer that crap right up
Projects
None yet
Development

No branches or pull requests

1 participant