Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Auth Roles #295

Open
bio-boris opened this issue Jan 28, 2021 · 0 comments
Open

Cleanup Auth Roles #295

bio-boris opened this issue Jan 28, 2021 · 0 comments

Comments

@bio-boris
Copy link
Collaborator

Currently there are

  • Hardcoded EE2_ADMIN and EE2_ADMIN_RO roles
  • ROLES taken from SDKMR.config
  • HARDCODED roles in authorization.roles
  • ee2.authorization.roles.is_admin takes a configured role
  • ee2.authorization.roles.get_admin_role takes a passed in role

AC:

  • Fix where roles come from
  • Standardize one method of fetching/comparing roles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bio-boris