Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mongoengine context managers #287

Open
MrCreosote opened this issue Jan 21, 2021 · 0 comments
Open

Remove mongoengine context managers #287

MrCreosote opened this issue Jan 21, 2021 · 0 comments
Labels
code cleanup swiffer that crap right up

Comments

@MrCreosote
Copy link
Member

They're unnecessary. For example:

        with self.sdkmr.get_mongo_util().mongo_engine_connection():
            self.logger.debug(job.to_mongo().to_dict())
            job.save()
@MrCreosote MrCreosote added the code cleanup swiffer that crap right up label Jan 21, 2021
@MrCreosote MrCreosote mentioned this issue Feb 20, 2021
Merged
8 tasks
MrCreosote added a commit that referenced this issue Apr 6, 2021
@MrCreosote
Remove mongo engine context from to be altered files
1576724 
Not needed as per #287

Removing in a commit prior to integrating the new job requirements
resolution code to make that change easier to read
@MrCreosote MrCreosote mentioned this issue Apr 6, 2021
Merged
7 tasks
MrCreosote added a commit that referenced this issue Apr 6, 2021
@MrCreosote
DATAUP-389 - remove some MongoEngine context managers (#347)
0ffee25 
* Remove mongo engine context from to be altered files

Not needed as per #287

Removing in a commit prior to integrating the new job requirements
resolution code to make that change easier to read

* run black
@MrCreosote MrCreosote mentioned this issue Jul 8, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code cleanup swiffer that crap right up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrCreosote