Merge pull request #516 from gordicaleksa/update_random_doc

karpathy · web-flow · commit 1ce30fdc4acf · 2024-06-02T16:37:37.000-07:00
Add clarification on Box-Muller
diff --git a/llmc/rand.h b/llmc/rand.h
@@ -163,8 +163,8 @@ void uniform_(float* data, unsigned int numel, float from, float to, mt19937_sta
     }
 }
 
-// Box�Muller transform
-
+// Box-Muller transform: maps uniform random numbers to Gaussian distributed numbers
+// https://en.wikipedia.org/wiki/Box%E2%80%93Muller_transform
 void normal_fill_16(float* data, float mean, float std, mt19937_state* state) {
     #define EPSILONE 1e-12
     for (unsigned int t = 0; t < 8; t++) {

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,8 @@ void uniform_(float* data, unsigned int numel, float from, float to, mt19937_sta`
`163`	`163`	`}`
`164`	`164`	`}`
`165`	`165`
`166`		`-// Box�Muller transform`
`167`		`-`
	`166`	`+// Box-Muller transform: maps uniform random numbers to Gaussian distributed numbers`
	`167`	`+// https://en.wikipedia.org/wiki/Box%E2%80%93Muller_transform`
`168`	`168`	`void normal_fill_16(float* data, float mean, float std, mt19937_state* state) {`
`169`	`169`	`#define EPSILONE 1e-12`
`170`	`170`	`for (unsigned int t = 0; t < 8; t++) {`