Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ES6 import format #1

Open
SujitSingh opened this issue Mar 20, 2018 · 3 comments
Open

Support for ES6 import format #1

SujitSingh opened this issue Mar 20, 2018 · 3 comments

Comments

@SujitSingh
Copy link
Contributor

Hi,

Can we please implement support for ES6 import format for this plugin?

For reference you can reffer to this issue.
This will help us to import this plugin without compilation errors in Ionic/Angular(2 and above) without workaround.

@karandpr
Copy link
Owner

Sure. I will look into it in a week or so. 👍

@karandpr
Copy link
Owner

@SujitSingh . Plugin is using module.exports ....
Are you facing any issues importing ?

@SujitSingh
Copy link
Contributor Author

@karandpr yes it generates error saying "Cannot find module "cordova/exec". Import statement is -

import cdvRootBeer from 'cordova-plugin-android-rootbeer/www/plugin';

I am currently working on Ionic framework. The thing is, Ionic doesn't include cordova by default, which is required in this plugin. Thus the TypeScript compilation fails because it couldn't find cordova instance.

karandpr pushed a commit that referenced this issue Jun 12, 2018
Adding check for Magisk package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants