From 634e3ce15a5c779e8e6cd4be3448f66671fc8879 Mon Sep 17 00:00:00 2001 From: Kaan Burak Sener Date: Sat, 8 Jan 2022 22:24:04 +0200 Subject: [PATCH] remove unnecessary error return type after using log.Fatalf() --- cmd/main.go | 8 +------- internal/adapters/framework/left/grpc/rpc_test.go | 6 +----- internal/adapters/framework/right/db/db.go | 4 ++-- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/cmd/main.go b/cmd/main.go index ce09b0f..43df8f1 100644 --- a/cmd/main.go +++ b/cmd/main.go @@ -1,7 +1,6 @@ package main import ( - "log" "os" // application @@ -14,15 +13,10 @@ import ( ) func main() { - var err error - dbaseDriver := os.Getenv("DB_DRIVER") dsourceName := os.Getenv("DS_NAME") - dbAdapter, err := db.NewAdapter(dbaseDriver, dsourceName) - if err != nil { - log.Fatalf("failed to initiate dbase connection: %v", err) - } + dbAdapter := db.NewAdapter(dbaseDriver, dsourceName) defer dbAdapter.CloseDbConnection() // core diff --git a/internal/adapters/framework/left/grpc/rpc_test.go b/internal/adapters/framework/left/grpc/rpc_test.go index 9cf0bc7..d4d0406 100644 --- a/internal/adapters/framework/left/grpc/rpc_test.go +++ b/internal/adapters/framework/left/grpc/rpc_test.go @@ -26,17 +26,13 @@ const bufSize = 1024 * 1024 var lis *bufconn.Listener func init() { - var err error lis = bufconn.Listen(bufSize) grpcServer := grpc.NewServer() dbaseDriver := os.Getenv("DB_DRIVER") dsourceName := os.Getenv("DS_NAME") - dbAdapter, err := db.NewAdapter(dbaseDriver, dsourceName) - if err != nil { - log.Fatalf("failed to initiate dbase connection: %v", err) - } + dbAdapter := db.NewAdapter(dbaseDriver, dsourceName) // core core := arithmetic.New() diff --git a/internal/adapters/framework/right/db/db.go b/internal/adapters/framework/right/db/db.go index 5424701..e581794 100644 --- a/internal/adapters/framework/right/db/db.go +++ b/internal/adapters/framework/right/db/db.go @@ -16,7 +16,7 @@ type Adapter struct { } // NewAdapter creates a new Adapter -func NewAdapter(driverName, dataSourceName string) (*Adapter, error) { +func NewAdapter(driverName, dataSourceName string) *Adapter { // connect db, err := sql.Open(driverName, dataSourceName) if err != nil { @@ -29,7 +29,7 @@ func NewAdapter(driverName, dataSourceName string) (*Adapter, error) { log.Fatalf("db ping failure: %v", err) } - return &Adapter{db: db}, nil + return &Adapter{db: db} } // CloseDbConnection closes the db connection