Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GITHUB_URL in install.sh overridable #11691

Open
unguiculus opened this issue Jan 30, 2025 · 1 comment
Open

Make GITHUB_URL in install.sh overridable #11691

unguiculus opened this issue Jan 30, 2025 · 1 comment
Milestone
2025-02 Release C...

Comments

@unguiculus
Copy link
Contributor

We would like the GITHUB_URL in install.sh to be overridable.

Is your feature request related to a problem? Please describe.

We mirror the download URL in our Artifactory and would like to download from there. Currently, we do downloads separately and disable them in the script. However, that is not ideal because that way, we can't take advantage of the hash comparison logic in the script.

Describe the solution you'd like

Make environment variable GITHUB_URL overridable.
@unguiculus unguiculus mentioned this issue Jan 30, 2025
Merged
@brandond brandond moved this from New to To Test in K3s Development Jan 30, 2025
@brandond brandond added this to the 2025-02 Release Cycle milestone Jan 30, 2025
@brandond
Copy link
Member

no backports necessary for install script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
K3s Development
Status: To Test
Milestone
2025-02 Release Cycle
Development

No branches or pull requests
2 participants
@brandond @unguiculus