Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssm parameters does not work when ssm parameters are paginated #443

Closed
tozonaran opened this issue Feb 1, 2019 · 4 comments · Fixed by #583
Closed

ssm parameters does not work when ssm parameters are paginated #443

tozonaran opened this issue Feb 1, 2019 · 4 comments · Fixed by #583

Comments

@tozonaran
Copy link

When you have ssm parameters > 50 in your aws account, then parameters "on the second page" are not found

I had a similar issue with the AWS Cli where results are paginated to 50 results per "page".

https://docs.aws.amazon.com/cli/latest/reference/ssm/get-parameters-by-path.html
https://docs.aws.amazon.com/cli/latest/userguide/cli-usage-pagination.html

@tozonaran
Copy link
Author

Is there a --recursive param I can use?

@tozonaran
Copy link
Author

Looks like this is where the issue is https://github.com/k1LoW/awspec/blob/master/lib/awspec/helper/finder/ssm_parameter.rb#L13
I will try to fix in my spare time.

@tozonaran
Copy link
Author

Can anybody help me with this? here is my fix https://github.com/tozonaran/awspec/commit/4eac251835f72f76ab0160a6e73f3772fc9158a4

I had issues with updating the unit tests to reflect my new changes.

cthulhu pushed a commit to cthulhu/awspec that referenced this issue Aug 6, 2019
@cthulhu
Copy link

cthulhu commented Aug 6, 2019

Created PR, pls take a look. We monkey patched for our specs so far:
#481

cthulhu pushed a commit to cthulhu/awspec that referenced this issue Aug 6, 2019
cthulhu pushed a commit to cthulhu/awspec that referenced this issue Aug 6, 2019
@k1LoW k1LoW closed this as completed in #583 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants