[BUG] crash on iOS with new arch

[chriszs]

Describe the bug
App crashes with Attempted to dereference null pointer. when new arch/bridgeless is enabled and JWPlayer is viewed.

The crash appears to be in a string length check called indirectly by parseExportedMethods with a method selector of setUpCastController, a method signature of nil and a return type of v (void?), when attempting to call the signature. See below for screenshot.

If I had to guess, this may be because the cast methods are conditionally defined by #if USE_GOOGLE_CAST but the exported React Native method signatures may not be.

To Reproduce
Steps to reproduce the behavior:

1. Setup an app with JWPlayer, but don't enable Google Cast support
2. Enable new arch
3. Try to view a screen with JWPlayer on it

Expected behavior
No crash.

Screenshots / Visual evidence

Error occurs during a call on line 126 in the screenshot above.

[Jmilham21]

Hey @chriszs, I'll be on PTO from today until the end of the month. The rest of my team is aware of this and will look into it. I'm just giving you a heads-up if you don't see any motion for a bit.

This may become a larger issue as supporting the architecture will require some major refactoring of our classes (or at least that was my understanding the last time I read through the docs).

[chriszs]

@Jmilham21 That may no longer be the case with the Interop Layer, which in some cases requires almost no changes at all (see this five line change to enable it for Auth0, for instance), and those docs have evolved a ton, but I haven't yet confirmed that for JWPlayer. For me, this is not a priority, because in order to enable new arch multiple third party libraries would have to fix issues. But new arch will be the default when scaffolding new projects in the next major release of React Native (release date: TBA), and I suspect this particular crash could be relatively straightforward to address (though there can always be unforeseen complications).