Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pie-divider): DSW-2374 Refactored pie-divider to use page object #2128

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Dec 19, 2024

Describe your changes (can list changeset entries if preferable)

  • Added Divider test story to storybook testing folder
  • Added turbo.json to stop component building locally
  • Updated createVariantStory to support background dark mode prop for inverse view for pie-divider
  • Updated Component, Accessibility and Visual tests from @sand4rt/experimental-ct-web package to @playwright/test as well as corresponding playwright-lit configs.

Author Checklist (complete before requesting a review, do not delete any)

  • I have performed a self-review of my code.
  • [-] N/A I have added thorough tests where applicable (unit / component / visual).
  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have reviewed visual test updates properly before approving.
  • [-] N/A If changes will affect consumers of the package, I have created a changeset entry.
  • [-] N/A If a changeset file has been created, I have tested these changes in PIE Aperture using the /test-aperture command.

Reviewer checklists (complete before approving)

Mark items as [-] N/A if not applicable.

Reviewer 1

  • I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

Reviewer 2 – @ashleynolan

  • [-] NA - I have reviewed the PIE Storybook/PIE Docs PR preview.
  • I have verified that all acceptance criteria for this ticket have been completed.
  • [-] N/A I have reviewed the Aperture changes (if added)
  • If there are visual test updates, I have reviewed them.

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners December 19, 2024 12:34
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: f9122ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ashleynolan
Copy link
Contributor

@JoshuaNg2332 Looks good – only thing I wanted to check was that the font-size looks different in the new Percy checks compared to the originals. Is that expected?

@JoshuaNg2332 JoshuaNg2332 merged commit 3835c3f into main Jan 6, 2025
36 of 39 checks passed
@JoshuaNg2332 JoshuaNg2332 deleted the DSW-2374-divider-refactor branch January 6, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants