Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pie-docs): DSW-2178 add diagram to engineering Contributing Page #2127

Closed
wants to merge 1 commit into from

Conversation

leksaBoiko
Copy link
Contributor

@leksaBoiko leksaBoiko commented Dec 19, 2024

Describe your changes (can list changeset entries if preferable)

  • [Docsite] add diagram to engineering Contributing Page

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have reviewed the Docs site preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1 - @siggerzz

  • I have reviewed the Docs site preview
  • If new links have been added, I have tested them in the preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the Docs site preview
  • If new links have been added, I have tested them in the preview
  • If there are visual test updates, I have reviewed them

@leksaBoiko leksaBoiko self-assigned this Dec 19, 2024
@leksaBoiko leksaBoiko requested review from a team as code owners December 19, 2024 10:18
Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 79c7a6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pie-design-system-bot
Copy link
Contributor




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.

🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.

🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 79c7a6a

@leksaBoiko leksaBoiko closed this Dec 20, 2024
@leksaBoiko leksaBoiko deleted the dsw-2178-contributing-page-diagram branch December 20, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants