Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains for third-party requests #1

Open
dimqua opened this issue Aug 31, 2018 · 5 comments
Open

Domains for third-party requests #1

dimqua opened this issue Aug 31, 2018 · 5 comments

Comments

@dimqua
Copy link

dimqua commented Aug 31, 2018

Hi there, I noticed that your blocklists contain domains from rules like this: ||example.com^$third-party.
Why block them?

@swiftlyfalling
Copy link
Contributor

@dimqua: The configuration specific to that is currently here:

# For Adblock Plus format filter lists, include domain-only entries with the solo option "third-party"

Did you encounter a situation in which including these entries is problematic?

I suppose it would be possible to provide separate versions of the converted lists with them included and excluded.

@argonym
Copy link

argonym commented Nov 17, 2020

Hi @swiftlyfalling, the EasyLists are primarily meant for blocking inside browsers. In contrast, your justdomains are primarily used for DNS-based blocking. At least that's how we are using them.
So in case of DNS-based blocking it's obviously impossible to distinguish 2nd from 3rd party sites, and some over-blocking of domains flagged with the third-party option is to be expected.

Here are two particular peculiar cases:

download.microsoft.com         CNAME  20    Answer     2-01-4ca6-0004.cdx.cedexis.net

download.windowsupdate.com     CNAME  18    Answer     wu-fg-shim.trafficmanager.net
wu-fg-shim.trafficmanager.net  CNAME  18    Answer     2-01-3cf7-0009.cdx.cedexis.net

cedexis.net ist contained in easyprivacy with third-party. Seems to be a large DNS+CDN(+Tracking) provider.

Use cases vary. I think your approach of two versions of each list makes a lot of sense, and I'd appreciate if you made it happen. :)

@dimqua dimqua closed this as completed Nov 17, 2020
@argonym
Copy link

argonym commented Nov 18, 2020

@dimqua, why did you close this issue? Am I missing something?

@dimqua
Copy link
Author

dimqua commented Nov 18, 2020

@argonym I thought that the project is no longer maintained, but I was wrong. Only this repository isn't maintained.

@argonym
Copy link

argonym commented Nov 24, 2020

@dimqua: Please re-open this issue, as it still exists (regardless of the state of the project).
Maybe @swiftlyfalling is inclined to implement the change/feature. Or somebody else stumbling over it might make a PR.

@dimqua dimqua reopened this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants