Skip to content

Commit de45c79

Browse files
author
dhirschf
committed
Make baseUrl private and add getter/setter
1 parent ba0bcab commit de45c79

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

src/browser.ts

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,9 +127,17 @@ class GitHubFileBrowser extends Widget {
127127

128128
/**
129129
* The GitHub base URL
130-
* Set by the settingsRegistry change hook
131130
*/
132-
baseUrl: string;
131+
get baseUrl(): string {
132+
return this._baseUrl;
133+
}
134+
135+
/**
136+
* The GitHub base URL is set by the settingsRegistry change hook
137+
*/
138+
set baseUrl(url: string) {
139+
this._baseUrl = url;
140+
}
133141

134142
/**
135143
* React to a change in user.
@@ -251,6 +259,7 @@ class GitHubFileBrowser extends Widget {
251259

252260
private _browser: FileBrowser;
253261
private _drive: GitHubDrive;
262+
private _baseUrl: string;
254263
private _errorPanel: GitHubErrorPanel | null;
255264
private _openGitHubButton: ToolbarButton;
256265
private _launchBinderButton: ToolbarButton;

0 commit comments

Comments
 (0)