Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added collaborative_document_save_delay trait #13392

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Added collaborative_document_save_delay trait #13392

merged 2 commits into from
Nov 9, 2022

Conversation

davidbrochart
Copy link
Contributor

References

Closes jupyterlab/jupyter-collaboration#47.

Code changes

Add collaborative_document_save_delay trait.

User-facing changes

The delay before saving a document after a document change is parameterizable in collaborative mode (default to 1 second).

Backwards-incompatible changes

None.

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@ellisonbg
Copy link
Contributor

@davidbrochart thanks for opening this, where is the current default of 1s set?

@davidbrochart
Copy link
Contributor Author

See this comment.

fcollonval
fcollonval reviewed Nov 8, 2022
View reviewed changes
jupyterlab/labapp.py Outdated Show resolved Hide resolved
@fcollonval fcollonval added this to the 3.6.0 milestone Nov 8, 2022
@hbcarlos hbcarlos mentioned this pull request Nov 8, 2022
Closed
@davidbrochart davidbrochart force-pushed the collaborative_document_save_delay branch from 2bff1ec to 289f5d3 Compare November 9, 2022 07:37
@davidbrochart
Copy link
Contributor Author

oops I reverted the change to Float while rebasing.
BTW, if we make it a Float, we can remove allow_none since a float can be float("inf")?

@davidbrochart
Copy link
Contributor Author

BTW, if we make it a Float, we can remove allow_none since a float can be float("inf")?

But I don't know if it plays well with configuration, command line arguments, etc.
Let's keep it like that for now.

fcollonval
fcollonval approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fcollonval fcollonval merged commit e346084 into jupyterlab:master Nov 9, 2022
@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.6.x

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 9, 2022

Oops, something went wrong applying the patch ... Please have a look at my logs.

@davidbrochart davidbrochart deleted the collaborative_document_save_delay branch November 9, 2022 09:42
fcollonval pushed a commit to fcollonval/jupyterlab that referenced this pull request Nov 10, 2022
@davidbrochart @fcollonval
Backport jupyterlab#13392 on branch 3.6.x (Added collaborative_docume…
3d93785 
…nt_save_delay trait)
@fcollonval fcollonval mentioned this pull request Nov 10, 2022
Merged
fcollonval added a commit that referenced this pull request Nov 10, 2022
@fcollonval @davidbrochart
Backport #13392 on branch 3.6.x (Added collaborative_document_save_de…
1f8908f 
…lay trait) (#13404)

Co-authored-by: David Brochart <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fcollonval fcollonval fcollonval approved these changes

Assignees

@davidbrochart davidbrochart

Labels
enhancement
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Where/how to set collaborative_document_save_delay
3 participants
@davidbrochart @ellisonbg @fcollonval