Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.6.x compatibility with jupyter-collaboration #213

Open
dlqqq opened this issue Nov 12, 2023 · 5 comments
Open

3.6.x compatibility with jupyter-collaboration #213

dlqqq opened this issue Nov 12, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@dlqqq
Copy link
Member

dlqqq commented Nov 12, 2023

Problem

cc @hbcarlos @davidbrochart

Some users require JupyterLab 3.6.x and have noticed issues with the RTC feature at scale and at higher network latencies, which are frequently encountered in production. I am willing to submit fixes for these issues, but JupyterLab 3.6.x depends on jupyter_server_ydoc, which has been untouched since March 2023.

I would like to know 1) whether jupyter_server_ydoc is still officially supported, and 2) whether any versions of jupyter-collaboration are compatible with JupyterLab 3.6.x.

Proposed Solution

Document this in the jupyter-collaboration README.

If jupyter_server_ydoc is deprecated, then it seems like jupyter-collaboration compatibility should be backported to JupyterLab 3.6.x, as 3.6.x is still officially supported as far as I am aware.

@dlqqq dlqqq added the enhancement New feature or request label Nov 12, 2023
Copy link

welcome bot commented Nov 12, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@davidbrochart
Copy link
Collaborator

  1. whether jupyter_server_ydoc is still officially supported

jupyter_server_ydoc redirects to jupyter-collaboration. The repo was renamed and includes the TypeScript JupyterLab frontend code. Since there is no separate GitHub repo for jupyter_server_ydoc, I don't see how we can support it.

  1. whether any versions of jupyter-collaboration are compatible with JupyterLab 3.6.x.

I don't think so, but I will let @fcollonval confirm.

@dlqqq
Copy link
Member Author

dlqqq commented Nov 13, 2023

@davidbrochart Thanks for the prompt reply!

I believe our current support strategy is to support old major releases for one year. This means that we should still maintain some path to maintaining all RTC packages in JL 3.x (including jupyter_server_ydoc) until May 2024.

The repo was renamed and includes the TypeScript JupyterLab frontend code. Since there is no separate GitHub repo for jupyter_server_ydoc, I don't see how we can support it.

The 0.8.x branch in this repo still tracks jupyter_server_ydoc.

With this in mind, I have two questions:

  1. Would you be open to doing patch releases of jupyter_server_ydoc to fix RTC bugs experienced by JL 3.x users?

  2. If maintaining jupyter_server_ydoc is no longer possible, can we change the implementation in JL 3.x to use jupyter_collaboration instead, such that JL 3.x users experiencing RTC bugs can still be supported?

@davidbrochart
Copy link
Collaborator

I didn't follow the changes that were made after the move of jupyter_server_ydoc to jupyter-collaboration.
I'll let @hbcarlos and @fcollonval answer your questions.

@fcollonval
Copy link
Member

The branch 0.8.x is the one to update jupyter_server_ydoc used by JupyterLab 3.6.x as mentioned by @dlqqq. So it is possible to push new commits on it and release new version of jupyter_server_ydoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants